Merged
Conversation
Update compose.yaml Update compose.yaml Attempt to fix build issue Update compose.yaml Update compose.yaml Update debian-13-cpp.dockerfile
3bffa74 to
4ad2878
Compare
alinaliBQ
commented
Mar 20, 2026
| set(ZLIB_STATIC_LIB_NAME zlibstaticd.lib) | ||
| else() | ||
| set(ZLIB_STATIC_LIB_NAME zlibstatic.lib) | ||
| if(NOT TARGET ZLIB::ZLIB) |
Author
There was a problem hiding this comment.
Add if statement if(NOT TARGET ZLIB::ZLIB) to use bundled zlib only if zlib library is not found. On debian, there was build error without this change: https://github.com/Bit-Quill/arrow/actions/runs/23025621291/job/66872649956#step:6:4516
Other changes in this file are only empty space changes
alinaliBQ
commented
Mar 20, 2026
Comment on lines
+397
to
+413
| ARROW_ACERO: "OFF" | ||
| ARROW_AZURE: "OFF" | ||
| ARROW_BUILD_TYPE: RELEASE | ||
| ARROW_CSV: "OFF" | ||
| ARROW_DATASET: "OFF" | ||
| ARROW_ENABLE_TIMING_TESTS: # inherit | ||
| ARROW_DEPENDENCY_SOURCE: BUNDLED | ||
| ARROW_DEPENDENCY_USE_SHARED: "OFF" | ||
| ARROW_FILESYSTEM: "OFF" | ||
| ARROW_FLIGHT_SQL_ODBC: "ON" | ||
| ARROW_GANDIVA: "OFF" | ||
| ARROW_GCS: "OFF" | ||
| ARROW_HDFS: "OFF" | ||
| ARROW_ORC: "OFF" | ||
| ARROW_PARQUET: "OFF" | ||
| ARROW_S3: "OFF" | ||
| ARROW_SUBSTRAIT: "OFF" |
Author
There was a problem hiding this comment.
Disabled non-ODBC related projects on Debian, since we ran into build errors with ARROW_PARQUET: https://github.com/Bit-Quill/arrow/actions/runs/23070284534/job/67018772931#step:6:11116
# New if statement attempts to fix https://github.com/Bit-Quill/arrow/actions/runs/23025621291/job/66872649956#step:6:4516 error # -AL- Disable parquet due to https://github.com/Bit-Quill/arrow/actions/runs/23070284534/job/67018772931#step:6:11116
4ad2878 to
fe0ac17
Compare
justing-bq
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ODBC Debian support in Linux CI.
Fixed Debian build issue with external library
ZLIB.