fix: correct bernoulli_loader kwarg, remove duplicate import, fix mutable default#743
Open
haoyu-haoyu wants to merge 1 commit intoBindsNET:masterfrom
Open
fix: correct bernoulli_loader kwarg, remove duplicate import, fix mutable default#743haoyu-haoyu wants to merge 1 commit intoBindsNET:masterfrom
haoyu-haoyu wants to merge 1 commit intoBindsNET:masterfrom
Conversation
…able default - Fix bernoulli_loader reading 'dt' instead of 'max_prob' from kwargs in encoding/loaders.py. The docstring documents max_prob but the code was fetching the wrong key. - Remove duplicate 'import numpy as np' in network/monitors.py. - Fix mutable default argument pipeline=[] in MulticompartmentConnection.__init__. Changed to None with guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
bernoulli_loaderreading wrong kwarg inbindsnet/encoding/loaders.py:kwargs.get("dt", 1.0)should bekwargs.get("max_prob", 1.0). The docstring documentsmax_probas the parameter for maximum spike probability per Bernoulli trial, but the code was readingdtinstead.Remove duplicate
import numpy as npinbindsnet/network/monitors.py.Fix mutable default argument
pipeline: list = []→pipeline: Optional[list] = NoneinMulticompartmentConnection.__init__(bindsnet/network/topology.py). Mutable defaults are shared across all instances.Test plan
bernoulli_loadernow correctly readsmax_probparametermax_prob(default remains 1.0)