Skip to content

Accessibility issues #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pragadeeshk merged 9 commits into from
Sep 27, 2022
Merged

Accessibility issues #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ec9ce5a
Set text as accessibility label when altText is not provided
pragadeeshk Jun 11, 2022
f4c0555
Added accessibility focus for image component
pragadeeshk Jun 11, 2022
48d8438
Fixed visualizer build issue for android (#90)
dan-arvi Aug 5, 2022
acd3ac3
Fix Hyperlink not working in a Bulleted List (#101)
Zaidos9 Sep 7, 2022
90ed274
React native version update to 0.68.2 (#93)
dan-arvi Sep 7, 2022
738a988
Version bump
pragadeeshk Sep 8, 2022
0c295a9
Merge branch 'reactnative/release-2.2.27' into accessibility-issues
pragadeeshk Sep 8, 2022
58c7fc6
Fixed alignment issue due to accessibility fix
pragadeeshk Sep 8, 2022
0c01bbc
Merge branch 'fork-main' into accessibility-issues
pragadeeshk Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions source/community/reactnative/src/components/elements/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
import React from 'react';
import {
StyleSheet,
Image
Image,
View
} from 'react-native';

import * as Utils from '../../utils/util';
Expand Down Expand Up @@ -273,19 +274,27 @@ export class Img extends React.Component {
}

getImageComponent(imageUrl, wrapperComputedStyle, imageComputedStyle) {
console.log(this.payload.altText);
return (
<ElementWrapper
configManager={this.props.configManager}
json={this.payload}
isFirst={this.props.isFirst}
style={wrapperComputedStyle}
onPageLayout={this.onPageLayoutHandler}>
<BaseImage
style={imageComputedStyle}
accessible={true}
accessibilityLabel={this.payload.altText}
source={{uri: imageUrl}}
/>
{
this.payload.altText ? <View
accessible={true}
accessibilityLabel={this.payload.altText}>
<BaseImage
style={imageComputedStyle}
source={{uri: imageUrl}}
/>
</View> : <BaseImage
style={imageComputedStyle}
source={{uri: imageUrl}}
/>
}
</ElementWrapper>
);
}
Expand Down
8 changes: 3 additions & 5 deletions source/community/reactnative/src/utils/markdown-formatter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,9 @@ export default class MarkdownFormatter extends React.PureComponent {
}

return (
this.altText ?
<View accessible={true} accessibilityLabel={this.altText}>
{this.renderText(this.text)}
</View> :
this.renderText(this.text)
<View accessible={true} accessibilityLabel={this.altText || this.text} style={{alignSelf: 'baseline'}}>
{this.renderText(this.text)}
</View>
);
}

Expand Down