Switch to Rouge for syntax highlighting and add dark syntax-highlighting theme#500
Merged
RobinDaugherty merged 4 commits intomasterfrom Dec 15, 2020
Merged
Conversation
and fix dark theme being affected by light theme
This comment has been minimized.
This comment has been minimized.
Pull Request Test Coverage Report for Build 423536419
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rouge seems to be more actively developed, and most importantly its CSS class names are compatible with Pygments, which means there are more up-to-date themes available for it.
I found a good source (a gist) for Solarized themes that included the Pygments variables, and I built them as SCSS using variables. In order to support dark theme when enabled by the user's (browser) preferences, the dark theme has to override the light theme's directives.