Skip to content

Hide "live shell" hint after console has been used#490

Merged
RobinDaugherty merged 2 commits intomasterfrom
feature/hide-live-shell-hint-after-use
Nov 4, 2020
Merged

Hide "live shell" hint after console has been used#490
RobinDaugherty merged 2 commits intomasterfrom
feature/hide-live-shell-hint-after-use

Conversation

@RobinDaugherty
Copy link
Member

@RobinDaugherty RobinDaugherty commented Nov 4, 2020

This is an implementation of the request in #315, but instead of removing the hint completely, it's shown only when the console has never been used.

The JS on the page sets a cookie when the user types in the console, and hides the hint if that cookie is present. (The cookie will expire after one year.)

2020-11-04 13 48 17

Closes #342
Fixes #315

@coveralls
Copy link

Pull Request Test Coverage Report for Build 346125630

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-10.8%) to 85.532%

Totals Coverage Status
Change from base Build 346059898: -10.8%
Covered Lines: 402
Relevant Lines: 470

💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 4, 2020

Pull Request Test Coverage Report for Build 346125630

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.344%

Totals Coverage Status
Change from base Build 346059898: 0.0%
Covered Lines: 448
Relevant Lines: 465

💛 - Coveralls

@RobinDaugherty RobinDaugherty merged commit 54aa288 into master Nov 4, 2020
@RobinDaugherty RobinDaugherty deleted the feature/hide-live-shell-hint-after-use branch November 4, 2020 18:59
@RobinDaugherty RobinDaugherty added this to the v2.9 milestone Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

“This is a live shell. Type in here.” gets old *really* fast.

2 participants