Improve editor support for virtual environments#488
Merged
RobinDaugherty merged 8 commits intomasterfrom Nov 4, 2020
Merged
Conversation
Adding support for BETTER_ERRORS_EDITOR env var.
cb2a5c5 to
4f95f3b
Compare
Pull Request Test Coverage Report for Build 346260966
💛 - Coveralls |
of passing an object that responds to #url.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BETTER_ERRORS_EDITORenv var, which is used instead ofEDITORif present.%{file_unencoded}replacement to editor formatting string, so when a URL needs to be unencoded, it doesn't require a Proc.BETTER_ERRORS_EDITOR_URLenv var, which allows the editor to be fully customized without modifying code.BETTER_ERRORS_VIRTUAL_PATHandBETTER_ERRORS_HOST_PATHwhich, used together, cause the virtual path to be stripped from file paths, and the host path to be prefixed.This refactors editor detection out of the
BetterErrorsclass into a newEditorclass, while preserving the call pattern onBetterErrors.editor=.