correction Of #82 #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplest solution for #82 would be just always checking string literals for HaveDependencyOnAny and HaveDependencyOnAll, and never for OnlyHaveDependenciesOnAnyOrNone, OnlyHaveDependenciesOnAny, OnlyHaveDependenciesOnAll, HaveDependencyOtherThan.
In the future, it would be nice to give the user possibility to decide if he or she wants to look for dependencies in string literals, but for now, this will do the job.
The small change in test class shows problems created by PR #82, and PR #86. All test will pass after merging this PR and #94.