support m4a file extension#358
Merged
renefloor merged 4 commits intoBaseflow:developfrom Dec 30, 2021
Merged
Conversation
renefloor
reviewed
Dec 29, 2021
Codecov Report
@@ Coverage Diff @@
## develop #358 +/- ##
===========================================
- Coverage 75.39% 75.28% -0.11%
===========================================
Files 22 23 +1
Lines 691 692 +1
===========================================
Hits 521 521
- Misses 170 171 +1
Continue to review full report at Codecov.
|
support m4a file extension Co-authored-by: Rene Floor <r.floor.1@gmail.com>
Contributor
|
Sorry about the analyzer, yours is the first PR since the new Flutter stable. If you want I can create a separate PR to fix the analyzer issues. |
Contributor
Author
Thanks, but I want to try fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
feature
The m4a audio file extension is not supported now.
🆕 What is the new behavior (if this is a feature change)?
The m4a audio file extension are already supported.
💥 Does this PR introduce a breaking change?
no
🐛 Recommendations for testing
Download the m4a audio file via http, and then play the file
📝 Links to relevant issues/docs
https://github.com/Baseflow/flutter_cache_manager/pull/172/files
🤔 Checklist before submitting