Don't delete file when file is already being deleted#185
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #185 +/- ##
========================================
Coverage 73.28% 73.28%
========================================
Files 13 13
Lines 423 423
========================================
Hits 310 310
Misses 113 113
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bugfix
When a file is old and over capacity the store tries to delete the file twice
🆕 What is the new behavior (if this is a feature change)?
It only deletes it once.
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
I wrote a test, but it didn't fail, because file.exists() is very fast with memory filesystem. Automated testing only realy works when you force a delay in the code, which is not nice.
📝 Links to relevant issues/docs
fixes #184 and fixes Baseflow/flutter_cached_network_image#335
🤔 Checklist before submitting