Overload Information in Labor History Enhancement#563
Overload Information in Labor History Enhancement#563JohnCox2211 wants to merge 13 commits intodevelopmentfrom
Conversation
some wording need to figure out how to show overload approver name
to access overload info in the template
Known issues as of 2/5/26:
|
added back accidental feature deletions still need to fix adjustment pending page on pending forms page
for readability modified overload info display html
form modal giving error w/ no review date
pending adjustment forms page to not load properly. Seems like some departments are just showing up as None for some reason, should probably fix that
got rid of prints changed html logic for labor history modal
|
I think it would be a good idea to bold these texts: the labor office contact, the labor review date, and the reason for overload. 
|
The reason why I ended up not bolding the text was to match the appearance of the additional information already in place for release forms. I do agree that both would look better if they stood out more, so I have implemented this change for both as well the extra info popup for adjusted forms. |
|
Possible conflicting semi-related issues you may run into:
Note: both of the above issues are in the development branch as well and should be fixed in another issue. |
added bold text labels in labor form extra info rows modified peewee query made some jinja a bit more readable
The box text area is missleading it seems interactive when in fact it is not. We can have a better UI where it is merely a display, and the presentation is not misleading. Is there a reason that is the case?
|
The reason this textbox is kept this way is that it is the same as the release form (which you screenshotted). I kept that format for the overload forms for consistency. Though I agree that it would look better if it were disabled, so I implemented that change for the release and overload text areas |
overload forms in the student history modal to prevent user confusion
| form.adjustedForm.newValue = newDepartment.DEPT_NAME if newDepartment else "Unknown " + newValue | ||
| form.adjustedForm.oldValue = oldDepartment.DEPT_NAME if oldDepartment else "Unknown " + oldValue |
There was a problem hiding this comment.
Could we possibly get rid of the "unknown" and just put the new value to make it cleaner?
There was a problem hiding this comment.
This line is more of an error catching for another problem, and is meant just to allow the modal to open up when you encounter one of the known errors mentioned in a previous comment I made. This is what that ends up looking like:
Fixes issue #536
Changes:
Adds visibility into the overload form process for individual forms on the student Labor History page. This includes sections for notes on an overload rejection, the labor office contact for a form, the labor office's review date for the form, and the student's reason for the overload.
Testing:
Student Search:
- Find a student with overload forms (I found Nicholas Hamilton to be a good example)
- Open a form on the student's page with the overload status
- If the form was approved or pending, there should be a section with a labor office contact, labor review date, and the student's reason for overload.
- If the form was denied, the above section should be included, as well as one with a rejection reason from the reviewer.
Example (Denied form with no contact listed):
Example (approved form with a contact listed):