Dynamic search and load time optimization#529
Merged
BrianRamsay merged 45 commits intodevelopmentfrom Nov 19, 2025
Merged
Conversation
…borStatusForms table
…dentSoftwareDevTeam/lsf into optimize-supervisor-portal
…live search to supervisor portal to be modified to fit
from adminmanagement live search to supervisor portal to be modified to fit
adminManagement live search function, added IDs to the rest of the select divs, added event listeners for the selects
double entries in dropdown
… function remains now.
added debounce to live search
Contributor
|
It is a good implementation of the dynamic search. It has done the task of cutting down the loading time (optimization). Good job. |
Closed
BrianRamsay
previously requested changes
Sep 30, 2025
Contributor
BrianRamsay
left a comment
There was a problem hiding this comment.
The form doesn't remember the option chosen in the new search dropdowns after a page reload. It looks like the data returned is correctly reflecting it, but the supervisor (for example) doesn't show up as selected. If you check another box and Submit you get a datatables error.
…DevTeam/lsf into dynamic-search-supervisor-portal
…/BCStudentSoftwareDevTeam/lsf into dynamic-search-supervisor-portal
… because selectpicker.val() only works with an existing option, and doesn't create said option.
…Team/lsf into dynamic-search-supervisor-portal
… into dynamic-search-supervisor-portal
…ntSoftwareDevTeam/lsf into dynamic-search-supervisor-portal
…Team/lsf into dynamic-search-supervisor-portal
…es and pending forms.
…/BCStudentSoftwareDevTeam/lsf into dynamic-search-supervisor-portal
…y implemented the 'All Active Terms' as term option for select presets
BrianRamsay
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #502
First, we cut down unnecessary double-querying in the Supervisor Portal and removed a few hanging + unused queries.
Then, we added a dynamic search function for the supervisor portal for all of the dropdown boxes. This is so that when the page is loaded, the boxes with a lot of options are not prefilled with a large amount of HTML that's largely unused, as supervisors scarcely scan through the longer dropdowns, especially student names.
However, the Departments dropdown's functionality remains the same. Due to the small number of items in the dropdown, it's faster for users to simply scan through with their eyes and click, instead of searching.
Testing