Graduation management first page by Meatchema · Pull Request #1679 · BCStudentSoftwareDevTeam/celts

Meatchema · 2026-02-19T14:21:38Z

Issue Description

-Miss identified issue (solved) : The problem is that when the graduation check is clicked it says that the status has been confirmed and it works to create the graduated individual. But, if you uncheck their graduation status, they are no longer searchable under the ‘Senior' Status.
-Re-Identification of issue (solved): The actual problem is that from page two and onward if I click graduated for the user, the user will not disappear as they are supposed too. Only page one works.

Fixes #1679

Changes (2/24/26)

reorganized when the table is redrawn so that the page will stop switching after every graduate student selection.
Removed initialized page methods
removed direct event binding allowing handlers to work across multiple pages (allows buttons on page 2 and onward to work)

Changes

Added remove class 'hidden' and redraw table code so that status could go back to senior after being unchecked as graduated

Testing (New Problem Identified - 2/24/26)

-set in database/reset_database.sh from-backup

Click Admin, then 'Graduation Management'
Next you will chose a student (on page two or higher)
With the graduate toggle off (in its white form), click on the student's grad cap check box (their name should disappear)
However, the page you are on should stay the same

Testing (Previous Problem Identified)

-set in database/reset_database.sh from-backup

Click Admin, then 'Graduation Management'
Next you will chose a student, I usually use 'Monica' who is a senior
With the graduate toggle off (in its white form), click on Monicas grad cap check box (her name should disappear)
With the toggle still off, try to search her name in the search bar. You shouldn't be able to find her now that she is Alumni status
Next, switch the toggle on and search up Monica. (She should show up and her status should be Alumni)
Now, with the toggle still on, unclick Monica's grad cap button (She should still be visible since this version of the list includes both graduates and enrolled but now her status should say senior)

… not rsvp and have attended and or have not attended

… counted for two sections

…er details

… manage volunteer table can see ALL the volunteers added to the event

…tails.html

… finished updating waitlisted references for user in the checkbox

…ox is unchecked

app/controllers/admin/volunteers.py

Arohasina

-tested the changes, all work
-ran ./tests/run_tests.sh everything passed

All good on my side. If the second reviewer approves i believe this PR can be merged

bakobagassas

Hey! So for this issue I think there was a confusion. I recreated the testing in development and it seems to be working fine.

From my understanding, the issue should mainly be about the responsiveness of the pages that come after the first page on the graduation management page - not really the logic of the alumni thingy. Here is the description from Trello "The Graduation Management interface only works on the first page of data. Subsequent pages and searched students do not work.".

Also, there are a lot of commits in this PR that are not related to the graduation management page.

…le pages

…or the page. (So it doesn't switch pages after every graduate selection)

app/logic/volunteerSpreadsheet.py

bakobagassas · 2026-03-09T17:53:36Z

app/controllers/admin/volunteers.py

    waitlistUser = list(set([obj for obj in eventRsvpData if obj.rsvpWaitlist]))
    rsvpUser = list(set([obj for obj in eventRsvpData if not obj.rsvpWaitlist ]))
-
+    attendedUser = list(set([obj for obj in eventParticipantData if not obj.rsvpWaitlist]))


We should not be changing RSVP in this PR

Oh, Im starting to notice. I think I may have built this branch off of my other PR. :( I will try to see if I can remove these code pieces safely without messing up this PR. (I will leave comments again once this is complete.)

bakobagassas · 2026-03-09T17:55:16Z

app/templates/events/volunteerDetails.html


 {% macro createCheckbox(checkboxName) %}
-    {% set labelText = "RSVP" if checkboxName == 'rsvp' else 'Waitlist' if checkboxName == 'waitlist' else 'Attended' %}
+    {%- set labelMap = {


We should not change this file, as it does not have to do with graduation managment

This was the result of a merge issue. The "new" code was actually the previous code before the code in red which was new code that I had accidentally accepted due to the merge conflict.

bakobagassas · 2026-03-09T17:56:19Z

app/logic/participants.py


-        # put the rest of the users that are not on the waitlist into the volunteer data
-        eventVolunteerData = [volunteer for volunteer in eventNonAttendedData if volunteer not in eventWaitlistData]
+        # put all participants and non-waitlisted RSVPs into the volunteer data


We should not change this file either, as it does not have to do with graduation management.

github-actions · 2026-03-11T19:39:50Z

View Code Coverage

Meatchema added 15 commits January 22, 2026 16:17

Added in InvitedUser variable to differentiate between users who were…

11fc7da

… not rsvp and have attended and or have not attended

Merge branch 'development' into issue-1663-change-rsvp-language

7f7db93

Merge branch 'development' into issue-1663-change-rsvp-language

f97f9f3

Merge branch 'development' into issue-1663-change-rsvp-language

11a372e

Fixed the user's Invited label in the table and card

fa303f1

Fixed the entry counter in 'volunteer details'-html printParticipants…

79180c3

… counted for two sections

Removed datetime restriction so that scanned user can show in volunte…

fb6af41

…er details

changed eventVolunteerData to include non-waitlist RSVP's so that the…

12ebcff

… manage volunteer table can see ALL the volunteers added to the event

Removed resourceReader import statement

d977e8a

Merge branch 'development' into issue-1663-change-rsvp-language

0009316

Merge branch 'development' into issue-1663-change-rsvp-language

286cee0

Merge branch 'development' into issue-1663-change-rsvp-language

a3ee57d

I have changed the verbage from waitlist to waitlisted in volunteerDe…

8fb9053

…tails.html

Changed createCheckbox to a dictionary to increase readability. Also,…

2440ebb

… finished updating waitlisted references for user in the checkbox

removed hidden class to show the Senior status after graduate check b…

c42cd9d

…ox is unchecked

Meatchema self-assigned this Feb 19, 2026

Meatchema requested a review from bakobagassas February 19, 2026 14:21

Arohasina self-requested a review February 19, 2026 20:26

Arohasina reviewed Feb 19, 2026

View reviewed changes

app/controllers/admin/volunteers.py Show resolved Hide resolved

Arohasina reviewed Feb 19, 2026

View reviewed changes

added the laborAttendanceByTerm function

1fe7b84

bakobagassas requested changes Feb 20, 2026

View reviewed changes

Meatchema added 2 commits February 24, 2026 10:28

removed direct event binding allowing handlers to work accross multip…

2680d7b

…le pages

reorganized the code so that the page saves after updating the data f…

f922a9c

…or the page. (So it doesn't switch pages after every graduate selection)

Meatchema requested review from Arohasina, Kafui123 and bakobagassas February 24, 2026 15:44

Meatchema added 3 commits March 6, 2026 14:04

Merge branch 'development' into graduation-management-first-page

2ac2493

Merge branch 'development' into graduation-management-first-page

dda493d

reverted incoming changes to previous changes to make code work again

b6ee7f9

bakobagassas reviewed Mar 10, 2026

View reviewed changes

Merge branch 'development' into graduation-management-first-page

9a1a508

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graduation management first page#1679

Graduation management first page#1679
Meatchema wants to merge 22 commits intodevelopmentfrom
graduation-management-first-page

Meatchema commented Feb 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Arohasina left a comment

Uh oh!

bakobagassas left a comment •

edited

Loading

Uh oh!

Uh oh!

bakobagassas Mar 9, 2026

Uh oh!

Meatchema Mar 11, 2026

Uh oh!

bakobagassas Mar 9, 2026

Uh oh!

Meatchema Mar 11, 2026

Uh oh!

bakobagassas Mar 9, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Meatchema commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Description

Changes (2/24/26)

Changes

Testing (New Problem Identified - 2/24/26)

Testing (Previous Problem Identified)

Uh oh!

Uh oh!

Arohasina left a comment

Choose a reason for hiding this comment

Uh oh!

bakobagassas left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bakobagassas Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Meatchema Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

bakobagassas Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Meatchema Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

bakobagassas Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Meatchema commented Feb 19, 2026 •

edited

Loading

bakobagassas left a comment •

edited

Loading