Skip to content

feat: lecture blank error #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnny19991006 merged 3 commits into from
Apr 2, 2024
Merged

feat: lecture blank error #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dca635
fix: 곡백 문자 처리
seongjae6751 Apr 2, 2024
a93940e
chore: log 제거
seongjae6751 Apr 2, 2024
4ebf3ef
style: μ½”λ“œ 효율적으둜 μ „ν™˜
seongjae6751 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/in/koreatech/koin/domain/timetable/dto/LectureResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public static List<Long> toListClassTime(String classTime) {
List<String> numbers = List.of(classTime.split(","));

return numbers.stream()
.map(String::strip)
.map(Long::parseLong)
.toList();
}
Expand Down
10 changes: 3 additions & 7 deletions src/test/java/in/koreatech/koin/acceptance/TimetableApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ void getSemesterLecture() {
.isEnglish("N")
.designScore("0")
.isElearning("N")
.classTime("[200,201,202,203,204,205,206,207]")
.classTime("[200, 201, 202, 203, 204, 205, 206, 207]")
.build();

Lecture lecture2 = Lecture.builder()
Expand Down Expand Up @@ -88,7 +88,6 @@ void getSemesterLecture() {
.param("semester_date", lecture1.getSemester())
.get("/lectures")
.then()
.log().all()
.statusCode(HttpStatus.OK.value())
.extract();

Expand Down Expand Up @@ -136,7 +135,7 @@ void getSemesterLectures() {
.isEnglish("N")
.designScore("0")
.isElearning("N")
.classTime("[200,201,202,203,204,205,206,207]")
.classTime("[200, 201, 202, 203, 204, 205, 206, 207]")
.build();

Lecture lecture2 = Lecture.builder()
Expand Down Expand Up @@ -181,7 +180,6 @@ void getSemesterLectures() {
.param("semester_date", lecture1.getSemester())
.get("/lectures")
.then()
.log().all()
.statusCode(HttpStatus.OK.value())
.extract();

Expand All @@ -206,7 +204,7 @@ void isNotSemester() {
.isEnglish("N")
.designScore("0")
.isElearning("N")
.classTime("[200,201,202,203,204,205,206,207]")
.classTime("[200, 201, 202, 203, 204, 205, 206, 207]")
.build();

Lecture lecture2 = Lecture.builder()
Expand Down Expand Up @@ -234,7 +232,6 @@ void isNotSemester() {
.param("semester_date", 20193)
.get("/lectures")
.then()
.log().all()
.statusCode(HttpStatus.NOT_FOUND.value())
.extract();
}
Expand All @@ -256,7 +253,6 @@ void findAllSemesters() {
.when()
.get("/semesters")
.then()
.log().all()
.statusCode(HttpStatus.OK.value())
.extract();

Expand Down