Add getting started for Cosmos DB#675
Merged
Merged
Conversation
sajeetharan
commented
Aug 8, 2022
Member
- add getting started sample for Azure cosmos db
- fix typos
sajeetharan
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
seantleonard,
severussundar,
swviswan and
tarazou9
as code owners
August 8, 2022 13:33
Contributor
|
@sajeetharan Would you please try to mask off the Primary Key and Second Key info from the connection screenshot? |
Member
Author
|
@tarazou9 This screen shot is taken from the existing documentation and these keys are already rotated and not valid. We are using that as a consistent screenshot in all getting started https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-api-get-started#Connect |
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
requested changes
Aug 9, 2022
Aniruddh25
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding these changes for Cosmos db!
Waiting for a few nit bits.
Aniruddh25
reviewed
Aug 9, 2022
Aniruddh25
reviewed
Aug 9, 2022
seantleonard
requested changes
Aug 9, 2022
seantleonard
left a comment
Contributor
There was a problem hiding this comment.
Few changes requested. Also, GitHub indicates that samples/getting-started/schema.gql is an empty file. Is that intentional?
Member
Author
|
@seantleonard Yes it's intentional, as the schema file content would be generated as they execute the steps given in the getting started for Cosmos DB similar to the config file |
seantleonard
approved these changes
Aug 11, 2022
seantleonard
left a comment
Contributor
There was a problem hiding this comment.
two last nits, then should be good to go
…waii-engine into sajeetharan-doc-update-cosmos # Conflicts: # Hawaii-Cli/README.md
Member
Author
|
@seantleonard can you check and merge ! thank you |
seantleonard
enabled auto-merge (squash)
August 12, 2022 17:05
seantleonard
pushed a commit
that referenced
this pull request
Aug 15, 2022
* add getting started for Cosmos DB * fix PR comments and restructure * resolve PR comments * fix PR comments * commit missed changes * PR comment minor fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.