Skip to content

Fix two warnings in devtools_testutils folder #44282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dargilco wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Fix two warnings in devtools_testutils folder #44282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/tools/azure-sdk-tools/devtools_testutils/envvariable_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def _set_mgmt_settings_real_values(self):
user_auth = use_pwsh == "true" or use_cli == "true" or use_azd == "true"
if not user_auth:
# All variables are required for service principal authentication
_logger.warn(
_logger.warning(
"Environment variables for service principal credentials are not all set. "
"Please either set the variables or request user-based authentication by setting "
"an 'AZURE_TEST_USE_X_AUTH' environment variable to 'true'. See "
Expand Down
3 changes: 2 additions & 1 deletion eng/tools/azure-sdk-tools/devtools_testutils/preparers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import contextlib
import functools
import logging
import inspect
from collections import namedtuple
from threading import Lock

Expand Down Expand Up @@ -145,7 +146,7 @@ def _preparer_wrapper(test_class_instance, **kwargs):
except ImportError:
fn(test_class_instance, **trimmed_kwargs)
else:
if asyncio.iscoroutinefunction(fn):
if inspect.iscoroutinefunction(fn):
asyncio.run(fn(test_class_instance, **trimmed_kwargs))
else:
fn(test_class_instance, **trimmed_kwargs)
Expand Down
Loading