Skip to content

Delete src/DnsResolver/DnsResolver.Autorest/Az.DnsResolver.psd1#29459

Merged
NoriZC merged 1 commit into
mainfrom
VeryEarly-patch-3
Apr 28, 2026
Merged

Delete src/DnsResolver/DnsResolver.Autorest/Az.DnsResolver.psd1#29459
NoriZC merged 1 commit into
mainfrom
VeryEarly-patch-3

Conversation

@VeryEarly

Copy link
Copy Markdown
Collaborator

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings April 27, 2026 13:04
@azure-client-tools-bot-prd

Copy link
Copy Markdown
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR deletes the tracked Az.DnsResolver.psd1 module manifest from the src/DnsResolver/DnsResolver.Autorest/ folder, likely to avoid keeping generated module artifacts in source control for the DnsResolver AutoRest project.

Changes:

  • Removed src/DnsResolver/DnsResolver.Autorest/Az.DnsResolver.psd1.
Comments suppressed due to low confidence (2)

src/DnsResolver/DnsResolver.Autorest/Az.DnsResolver.psd1:1

  • The PR removes the only tracked module manifest under src/DnsResolver/DnsResolver.Autorest/, but the PR description doesn’t explain why this file is being deleted or what the intended source-of-truth manifest should be (e.g., the generated copy under generated/DnsResolver/DnsResolver.Autorest/Az.DnsResolver.psd1). Please add a brief rationale and confirm which manifest path should be used for local dev/test workflows.
    src/DnsResolver/DnsResolver.Autorest/Az.DnsResolver.psd1:1
  • If this manifest is meant to be generated (as in most *.Autorest folders), consider also updating src/DnsResolver/DnsResolver.Autorest/.gitignore to ignore /*.psd1 (other modules like src/Advisor/Advisor.Autorest/.gitignore and src/Quota/Quota.Autorest/.gitignore already do). Without that, a locally generated Az.DnsResolver.psd1 will show up as an unignored file and is easy to accidentally re-add in a future PR.

@NoriZC NoriZC merged commit cd907cc into main Apr 28, 2026
16 checks passed
@VeryEarly VeryEarly deleted the VeryEarly-patch-3 branch April 28, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants