Skip to content

[PS] Migrate DnsResolver module to autorest v4#28695

Merged
Pan-Qi merged 23 commits into
mainfrom
joyer/dnsresolver-migrate-v4
May 14, 2026
Merged

[PS] Migrate DnsResolver module to autorest v4#28695
Pan-Qi merged 23 commits into
mainfrom
joyer/dnsresolver-migrate-v4

Conversation

@JoyerJin

@JoyerJin JoyerJin commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Description

Preannouncement PR:

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd

Copy link
Copy Markdown
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi added Contains Breaking Change This PR contains breaking change autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 labels Jan 9, 2026
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@JiaSeng-v

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI review requested due to automatic review settings January 13, 2026 07:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request migrates the DnsResolver module from AutoRest v3 to AutoRest v4, introducing new features available in the updated code generator. The changes primarily involve regenerated help documentation, breaking change exception tracking, and minor namespace updates.

Changes:

  • Upgraded help documentation with new parameter sets and corrected SYNOPSIS descriptions across all cmdlets
  • Added breaking change exceptions CSV file to track API compatibility issues introduced by the migration
  • Updated module manifest dependencies and metadata
  • Modified namespace references from Api20230701Preview to simplified model namespaces

Reviewed changes

Copilot reviewed 188 out of 188 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/DnsResolver/DnsResolver/ChangeLog.md Added entry documenting AutoRest v4 upgrade
src/DnsResolver/DnsResolver/Az.DnsResolver.psd1 Updated Az.Accounts dependency, generation date, and formatting
tools/StaticAnalysis/Exceptions/Az.DnsResolver/BreakingChangeIssues.csv New file tracking 82 breaking changes from AutoRest migration
src/DnsResolver/DnsResolver/help/*.md Updated SYNOPSIS from "Creates/Updates" to "Create/Update" and added new parameter sets
src/DnsResolver/DnsResolver.Autorest/docs/*.md Similar help updates with parameter set additions
src/DnsResolver/DnsResolver.sln Updated project GUID
src/DnsResolver/DnsResolver.Autorest/generate-info.json Updated generation ID
src/DnsResolver/DnsResolver.Autorest/custom/csharp/*.cs Updated namespace from Api20230701Preview to simplified Models

@isra-fel

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@JiaSeng-v JiaSeng-v marked this pull request as ready for review January 14, 2026 00:05
@isra-fel isra-fel added this to the Az 16.0.0 (TBD) milestone Jan 28, 2026
@jamesvoongms

Copy link
Copy Markdown
Member

Thanks @JoyerJin, I am on the private resolver team and will re-record the tests for the PR

@jamesvoongms

Copy link
Copy Markdown
Member

As mentioned in email, I have added the re-recorded tests in #29285

The PR above must also be released in the same version as this as we were previously using a preview branch and main is missing these changes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@NoriZC

NoriZC commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@jamesvoongms

Copy link
Copy Markdown
Member

Please also wait on breaking change annoucement merge: #29308

Copilot AI review requested due to automatic review settings April 7, 2026 08:22
@JunKai-v

JunKai-v commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@khang-11 khang-11 changed the base branch from main to autorest-v4-breakingchange May 6, 2026 00:51
Francisco-Gamino and others added 6 commits May 6, 2026 10:53
Co-authored-by: JiaSeng-v <v-jiasenglaw@microsoft.com>
Co-authored-by: JunKai-v <v-juphang@microsoft.com>
Co-authored-by: JunKai-v <v-juphang@microsoft.com>
Co-authored-by: JiaSeng-v <v-jiasenglaw@microsoft.com>
@JunKai-v

JunKai-v commented May 6, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@khang-11 khang-11 changed the base branch from autorest-v4-breakingchange to main May 12, 2026 03:47
JunKai-v and others added 2 commits May 12, 2026 14:56
Resolve merge conflicts:
- Kusto files: accept upstream updates (unrelated to DnsResolver)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Re-ran autorest build workflow (autorest --debug, build-module.ps1, test-module.ps1 -Playback)
All 62 tests passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 12, 2026 07:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@JunKai-v

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@JunKai-v

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines successfully started running 3 pipeline(s).

@Pan-Qi Pan-Qi merged commit 16a0a85 into main May 14, 2026
14 checks passed
@JunKai-v JunKai-v deleted the joyer/dnsresolver-migrate-v4 branch June 12, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.