[AKS] az aks create/update: Add ephemeralDisk and elasticSan storag…
#32558
+339
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create update parameter enable_azure_container_storage: updated property nargs from ? to * |
||
| aks update | cmd aks update update parameter disable_azure_container_storage: updated property nargs from ? to * |
||
| aks update | cmd aks update update parameter enable_azure_container_storage: updated property nargs from ? to * |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for ephemeralDisk and elasticSan storage options to Azure Container Storage (ACStor) v2, enabling granular control over individual storage types. The changes allow users to enable/disable specific storage options via the CLI, rather than only being able to enable/disable the entire ACStor extension.
Key changes:
- Unified enable/disable operations into a single
perform_azure_container_storage_updatefunction - Added support for multiple storage option values in CLI arguments using comma-separated or space-separated lists
- Updated validators to handle individual storage option enablement/disablement with appropriate state checking
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test_validators.py | Updated test cases to validate new storage option parameters and error messages for ephemeralDisk and elasticSan |
| managed_cluster_decorator.py | Modified to call unified update function and pass storage options for enable/disable operations |
| acstor_ops.py | Refactored enable/disable functions into single perform_azure_container_storage_update function that handles both operations |
| _validators.py | Enhanced validation logic to support specific storage options (ephemeralDisk, elasticSan) and check their enabled state |
| _helpers.py | Added get_extension_installed_and_cluster_configs for v2 to retrieve storage option states and should_delete_extension helper |
| _params.py | Consolidated enable/disable argument type handlers into single _get_container_storage_enum_type function supporting multiple values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_validators.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/azurecontainerstorage/_helpers.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_validators.py
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Dec 19, 2025
Member
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_create_with_azurecontainerstorage_v1
- test_aks_create_with_azurecontainerstorage_v1_with_ephemeral_disk_parameters
- test_aks_update_with_azurecontainerstorage_v1
- test_aks_update_with_azurecontainerstorage_v1_with_ephemeral_disk_parameters
- test_aks_create_with_azurecontainerstorage
- test_aks_update_with_azurecontainerstorage
Member
|
Member
test_aks_create_with_azurecontainerstorage and test_aks_update_with_azurecontainerstorage failed
|
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Re-queued live test
|
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32558 in repo Azure/azure-cli |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
1b076d0 to
6e2b5ad
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Queued live test, test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e options for ACStor v2
Related command
az aks create/updateDescription
Supports CLI-driven storage option enablement for ACStor 2.1
Testing Guide
az aks create --enable-azure-container-storage: enables ACStor v2 without any storage options on a new cluster(can be enabled on demand via storage class)
az aks update --enable-azure-container-storage ephemeralDisk: enables the ephemeral disk storage option of ACStor v2az aks update --disable-azure-container-storage elasticSan: disables the elastic SAN storage option of ACStor v2az aks update --disable-azure-container-storage: completely disables ACStor v2History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.