Skip to content

{Core} Disable aladdin recommendation in autocomplete mode #25145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bebound merged 2 commits into from
Feb 1, 2023
Merged

{Core} Disable aladdin recommendation in autocomplete mode #25145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6c3022
Disable recommendation in autocomplete mode
bebound Jan 16, 2023
814841f
Remove is_autocomplete
bebound Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli-core/azure/cli/core/command_recommender.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ def _disable_aladdin_service(self):
1. CLI context is missing
2. In air-gapped clouds
3. In testing environments
4. In autocomplete mode

:return: whether Aladdin service need to be disabled or not
:type: bool
Expand All @@ -357,6 +358,9 @@ def _disable_aladdin_service(self):
if self.cli_ctx.__class__.__name__ == 'DummyCli':
return True

if self.cli_ctx.data['completer_active']:
return True

return False

def _normalize_parameters(self, args):
Expand Down