Skip to content

{Graph} Make msgraph internal and add documentation for GraphClient#22560

Merged
jiasli merged 4 commits into
Azure:devfrom
jiasli:msgraph
May 24, 2022
Merged

{Graph} Make msgraph internal and add documentation for GraphClient#22560
jiasli merged 4 commits into
Azure:devfrom
jiasli:msgraph

Conversation

@jiasli

@jiasli jiasli commented May 23, 2022

Copy link
Copy Markdown
Contributor

Related command

az ad

Description

Add documentation for GraphClient to assist with command modules and extensions' migration to Microsoft Graph (#22174).

Since extension developers sometimes instantiate GraphClient by themselves (Azure/azure-cli-extensions#4837), this PR forbids this usage by

  • Making msgraph internal as _msgraph
  • Adding example for using GraphClient

@ghost ghost requested a review from yonzhan May 23, 2022 06:53
@ghost ghost added the Auto-Assign Auto assign by bot label May 23, 2022
@ghost ghost requested a review from wangzelin007 May 23, 2022 06:53
@ghost ghost assigned jiasli May 23, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone May 23, 2022
@ghost ghost added the Graph (doesn't work with label-triggered comments; use Graph.Microsoft instead) az ad label May 23, 2022
@yonzhan

yonzhan commented May 23, 2022

Copy link
Copy Markdown
Collaborator

SDK users migration to MS Graph

Comment thread doc/microsoft_graph_client.md
@jiasli jiasli merged commit 710c821 into Azure:dev May 24, 2022
@jiasli jiasli deleted the msgraph branch May 24, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Graph (doesn't work with label-triggered comments; use Graph.Microsoft instead) az ad

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants