Skip to content

{Core} Aladdin recommendation improvements#17854

Merged
houk-ms merged 14 commits into
Azure:devfrom
houk-ms:aladdin-recommendation
Apr 26, 2021
Merged

{Core} Aladdin recommendation improvements#17854
houk-ms merged 14 commits into
Azure:devfrom
houk-ms:aladdin-recommendation

Conversation

@houk-ms

@houk-ms houk-ms commented Apr 25, 2021

Copy link
Copy Markdown
Contributor

Description

This PR provides two improvements for Aladdin recommendation

1. When users input duplicated parameters, we take only a distinct set of parameters and send them to Aladdin service.

For example, when user inputs az group create -g rg1 -g rg2 -g rg3, the parameters we send to Aladdin is [--resource-group], not [--resource-group, --resource-group, --resource-group] . Otherwise, aladdin service may throw Query Too Long error.

Even for the cases where multiple same parameters may make sense, the change won't affect the recommendation result.

2. Handle the cases where descriptions may not be provided for sample commands in help.py

Otherwise, the recommendation will just fail.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@houk-ms houk-ms added the Core CLI core infrastructure label Apr 25, 2021
@houk-ms houk-ms self-assigned this Apr 25, 2021
@houk-ms

houk-ms commented Apr 26, 2021

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@houk-ms houk-ms merged commit 39f4ecd into Azure:dev Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core CLI core infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants