-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Compute] disk create: Trusted launch; [Compute] disk create: Hibernation #17775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ba22b57
[Compute] disk create: Trusted launch; Hibernation
qwordy af43f38
test
qwordy 3517e7c
update
qwordy 0d930a3
Fix small issues caused by SDK
qwordy d55483b
Merge branch 'dev' of https://github.com/Azure/azure-cli into 17599
qwordy a96d2a6
test
qwordy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
230 changes: 230 additions & 0 deletions
230
...azure-cli/azure/cli/command_modules/vm/tests/latest/recordings/test_disk_hibernation.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,230 @@ | ||
| interactions: | ||
| - request: | ||
| body: null | ||
| headers: | ||
| Accept: | ||
| - application/json | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| CommandName: | ||
| - disk create | ||
| Connection: | ||
| - keep-alive | ||
| ParameterSetName: | ||
| - -g -n --size-gb --support-hibernation | ||
| User-Agent: | ||
| - python/3.7.4 (Windows-10-10.0.19041-SP0) msrest/0.6.21 msrest_azure/0.6.3 | ||
| azure-mgmt-resource/12.1.0 Azure-SDK-For-Python AZURECLI/2.22.0 | ||
| accept-language: | ||
| - en-US | ||
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_disk_hibernation_000001?api-version=2020-10-01 | ||
| response: | ||
| body: | ||
| string: '{"id":"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_hibernation_000001","name":"cli_test_disk_hibernation_000001","type":"Microsoft.Resources/resourceGroups","location":"westus","tags":{"product":"azurecli","cause":"automation","date":"2021-04-20T05:39:09Z"},"properties":{"provisioningState":"Succeeded"}}' | ||
| headers: | ||
| cache-control: | ||
| - no-cache | ||
| content-length: | ||
| - '428' | ||
| content-type: | ||
| - application/json; charset=utf-8 | ||
| date: | ||
| - Tue, 20 Apr 2021 05:39:12 GMT | ||
| expires: | ||
| - '-1' | ||
| pragma: | ||
| - no-cache | ||
| strict-transport-security: | ||
| - max-age=31536000; includeSubDomains | ||
| vary: | ||
| - Accept-Encoding | ||
| x-content-type-options: | ||
| - nosniff | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
| - request: | ||
| body: '{"location": "westus", "tags": {}, "sku": {"name": "Premium_LRS"}, "properties": | ||
| {"creationData": {"createOption": "Empty"}, "diskSizeGB": 10, "supportsHibernation": | ||
| true}}' | ||
| headers: | ||
| Accept: | ||
| - application/json | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| CommandName: | ||
| - disk create | ||
| Connection: | ||
| - keep-alive | ||
| Content-Length: | ||
| - '172' | ||
| Content-Type: | ||
| - application/json | ||
| ParameterSetName: | ||
| - -g -n --size-gb --support-hibernation | ||
| User-Agent: | ||
| - AZURECLI/2.22.0 azsdk-python-azure-mgmt-compute/20.0.0 Python/3.7.4 (Windows-10-10.0.19041-SP0) | ||
| method: PUT | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_hibernation_000001/providers/Microsoft.Compute/disks/d1?api-version=2020-12-01 | ||
| response: | ||
| body: | ||
| string: "{\r\n \"name\": \"d1\",\r\n \"location\": \"westus\",\r\n \"tags\": | ||
| {},\r\n \"sku\": {\r\n \"name\": \"Premium_LRS\"\r\n },\r\n \"properties\": | ||
| {\r\n \"supportsHibernation\": true,\r\n \"creationData\": {\r\n \"createOption\": | ||
| \"Empty\"\r\n },\r\n \"diskSizeGB\": 10,\r\n \"provisioningState\": | ||
| \"Updating\",\r\n \"isArmResource\": true\r\n }\r\n}" | ||
| headers: | ||
| azure-asyncoperation: | ||
| - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/DiskOperations/9504fd49-3f8b-48f4-b1d8-d97d3f8d71e0?api-version=2020-12-01 | ||
| cache-control: | ||
| - no-cache | ||
| content-length: | ||
| - '314' | ||
| content-type: | ||
| - application/json; charset=utf-8 | ||
| date: | ||
| - Tue, 20 Apr 2021 05:39:16 GMT | ||
| expires: | ||
| - '-1' | ||
| location: | ||
| - https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/DiskOperations/9504fd49-3f8b-48f4-b1d8-d97d3f8d71e0?monitor=true&api-version=2020-12-01 | ||
| pragma: | ||
| - no-cache | ||
| server: | ||
| - Microsoft-HTTPAPI/2.0 | ||
| - Microsoft-HTTPAPI/2.0 | ||
| strict-transport-security: | ||
| - max-age=31536000; includeSubDomains | ||
| x-content-type-options: | ||
| - nosniff | ||
| x-ms-ratelimit-remaining-resource: | ||
| - Microsoft.Compute/CreateUpdateDisks3Min;999,Microsoft.Compute/CreateUpdateDisks30Min;7992 | ||
| x-ms-ratelimit-remaining-subscription-writes: | ||
| - '1199' | ||
| status: | ||
| code: 202 | ||
| message: Accepted | ||
| - request: | ||
| body: null | ||
| headers: | ||
| Accept: | ||
| - '*/*' | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| CommandName: | ||
| - disk create | ||
| Connection: | ||
| - keep-alive | ||
| ParameterSetName: | ||
| - -g -n --size-gb --support-hibernation | ||
| User-Agent: | ||
| - AZURECLI/2.22.0 azsdk-python-azure-mgmt-compute/20.0.0 Python/3.7.4 (Windows-10-10.0.19041-SP0) | ||
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/DiskOperations/9504fd49-3f8b-48f4-b1d8-d97d3f8d71e0?api-version=2020-12-01 | ||
| response: | ||
| body: | ||
| string: "{\r\n \"startTime\": \"2021-04-20T05:39:17.2214047+00:00\",\r\n \"endTime\": | ||
| \"2021-04-20T05:39:17.3620232+00:00\",\r\n \"status\": \"Succeeded\",\r\n | ||
| \ \"properties\": {\r\n \"output\": {\r\n \"name\": \"d1\",\r\n \"id\": | ||
| \"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_hibernation_000001/providers/Microsoft.Compute/disks/d1\",\r\n | ||
| \ \"type\": \"Microsoft.Compute/disks\",\r\n \"location\": \"westus\",\r\n | ||
| \ \"tags\": {},\r\n \"sku\": {\r\n \"name\": \"Premium_LRS\",\r\n \"tier\": | ||
| \"Premium\"\r\n },\r\n \"properties\": {\r\n \"supportsHibernation\": | ||
| true,\r\n \"creationData\": {\r\n \"createOption\": \"Empty\"\r\n | ||
| \ },\r\n \"diskSizeGB\": 10,\r\n \"diskIOPSReadWrite\": 120,\r\n \"diskMBpsReadWrite\": | ||
| 25,\r\n \"encryption\": {\r\n \"type\": \"EncryptionAtRestWithPlatformKey\"\r\n | ||
| \ },\r\n \"timeCreated\": \"2021-04-20T05:39:17.2214047+00:00\",\r\n | ||
| \ \"provisioningState\": \"Succeeded\",\r\n \"diskState\": \"Unattached\",\r\n | ||
| \ \"diskSizeBytes\": 10737418240,\r\n \"uniqueId\": \"67ccf1b4-0154-4ba5-a4d9-26494bb0c221\",\r\n | ||
| \ \"networkAccessPolicy\": \"AllowAll\",\r\n \"tier\": \"P3\"\r\n }\r\n}\r\n | ||
| \ },\r\n \"name\": \"9504fd49-3f8b-48f4-b1d8-d97d3f8d71e0\"\r\n}" | ||
| headers: | ||
| cache-control: | ||
| - no-cache | ||
| content-length: | ||
| - '1145' | ||
| content-type: | ||
| - application/json; charset=utf-8 | ||
| date: | ||
| - Tue, 20 Apr 2021 05:39:19 GMT | ||
| expires: | ||
| - '-1' | ||
| pragma: | ||
| - no-cache | ||
| server: | ||
| - Microsoft-HTTPAPI/2.0 | ||
| - Microsoft-HTTPAPI/2.0 | ||
| strict-transport-security: | ||
| - max-age=31536000; includeSubDomains | ||
| transfer-encoding: | ||
| - chunked | ||
| vary: | ||
| - Accept-Encoding | ||
| x-content-type-options: | ||
| - nosniff | ||
| x-ms-ratelimit-remaining-resource: | ||
| - Microsoft.Compute/GetOperation3Min;49996,Microsoft.Compute/GetOperation30Min;399964 | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
| - request: | ||
| body: null | ||
| headers: | ||
| Accept: | ||
| - '*/*' | ||
| Accept-Encoding: | ||
| - gzip, deflate | ||
| CommandName: | ||
| - disk create | ||
| Connection: | ||
| - keep-alive | ||
| ParameterSetName: | ||
| - -g -n --size-gb --support-hibernation | ||
| User-Agent: | ||
| - AZURECLI/2.22.0 azsdk-python-azure-mgmt-compute/20.0.0 Python/3.7.4 (Windows-10-10.0.19041-SP0) | ||
| method: GET | ||
| uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_hibernation_000001/providers/Microsoft.Compute/disks/d1?api-version=2020-12-01 | ||
| response: | ||
| body: | ||
| string: "{\r\n \"name\": \"d1\",\r\n \"id\": \"/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/cli_test_disk_hibernation_000001/providers/Microsoft.Compute/disks/d1\",\r\n | ||
| \ \"type\": \"Microsoft.Compute/disks\",\r\n \"location\": \"westus\",\r\n | ||
| \ \"tags\": {},\r\n \"sku\": {\r\n \"name\": \"Premium_LRS\",\r\n \"tier\": | ||
| \"Premium\"\r\n },\r\n \"properties\": {\r\n \"supportsHibernation\": | ||
| true,\r\n \"creationData\": {\r\n \"createOption\": \"Empty\"\r\n | ||
| \ },\r\n \"diskSizeGB\": 10,\r\n \"diskIOPSReadWrite\": 120,\r\n \"diskMBpsReadWrite\": | ||
| 25,\r\n \"encryption\": {\r\n \"type\": \"EncryptionAtRestWithPlatformKey\"\r\n | ||
| \ },\r\n \"timeCreated\": \"2021-04-20T05:39:17.2214047+00:00\",\r\n | ||
| \ \"provisioningState\": \"Succeeded\",\r\n \"diskState\": \"Unattached\",\r\n | ||
| \ \"diskSizeBytes\": 10737418240,\r\n \"uniqueId\": \"67ccf1b4-0154-4ba5-a4d9-26494bb0c221\",\r\n | ||
| \ \"networkAccessPolicy\": \"AllowAll\",\r\n \"tier\": \"P3\"\r\n }\r\n}" | ||
| headers: | ||
| cache-control: | ||
| - no-cache | ||
| content-length: | ||
| - '920' | ||
| content-type: | ||
| - application/json; charset=utf-8 | ||
| date: | ||
| - Tue, 20 Apr 2021 05:39:19 GMT | ||
| expires: | ||
| - '-1' | ||
| pragma: | ||
| - no-cache | ||
| server: | ||
| - Microsoft-HTTPAPI/2.0 | ||
| - Microsoft-HTTPAPI/2.0 | ||
| strict-transport-security: | ||
| - max-age=31536000; includeSubDomains | ||
| transfer-encoding: | ||
| - chunked | ||
| vary: | ||
| - Accept-Encoding | ||
| x-content-type-options: | ||
| - nosniff | ||
| x-ms-ratelimit-remaining-resource: | ||
| - Microsoft.Compute/LowCostGet3Min;4998,Microsoft.Compute/LowCostGet30Min;39968 | ||
| status: | ||
| code: 200 | ||
| message: OK | ||
| version: 1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there are still many unnoticed but ubiquitous attribute/model/function-name error caused by track2 upgrading.
Is it necessary to check them thoroughly in advance rather than fix them after issues raising?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. It is a disadvantage of dynamic language. We can't detect the error until runtime.