You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
offerType is default virtualmachine, this is behavior confirmed with Marketplace team.
Why this is a core module instead of extension?
Terms accepting is a general flow in mgmt plane e2e flow. It's a cross RP operation. Accepting term is a key step during RP registration, user will not able to use RP like LiftR specific commands without terms. Put it in core improving discoverability and availability to users. Secondly, marketplaceordering SDK is already a dependency in core repo from long time ago, this will not impact core package heavily.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
Should we use az term or az terms? It looks like terms is more common as a command name or option name.
use term to follow existing command group naming convention: single noun like vm, acr, keyvault etc. what's your thought?
Yes, it's more common to have single form noun as command group. I was think that it is more common to say accept terms than accept a term. For command group name, I think both forms are acceptable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MarketplaceOrdering RP https://docs.microsoft.com/en-us/rest/api/marketplaceordering/marketplaceagreements, API version 2021-01-01, on Track2 SDK. CodeGen readme config file: https://github.com/Azure/azure-rest-api-specs/pull/12484/files
az term acceptcovers term accpeting operation, calling into API PUT https://management.azure.com/subscriptions/{subscriptionId}/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/{publisherId}/offers/{offerId}/plans/{planId}/agreements/current?api-version=2021-01-01az term showcovers term show operation, calling into API GET https://management.azure.com/subscriptions/{subscriptionId}/providers/Microsoft.MarketplaceOrdering/offerTypes/virtualmachine/publishers/{publisherId}/offers/{offerId}/plans/{planId}/agreements/current?api-version=2021-01-01offerTypeis defaultvirtualmachine, this is behavior confirmed with Marketplace team.Why this is a core module instead of extension?
Terms accepting is a general flow in mgmt plane e2e flow. It's a cross RP operation. Accepting term is a key step during RP registration, user will not able to use RP like LiftR specific commands without terms. Put it in core improving discoverability and availability to users. Secondly, marketplaceordering SDK is already a dependency in core repo from long time ago, this will not impact core package heavily.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.