[dataprotection] Auto-install k8s-extension for AKS backup#9914
[dataprotection] Auto-install k8s-extension for AKS backup#9914anshulahuja98 wants to merge 4 commits into
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @anshulahuja98, |
|
k8s |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Bumps the dataprotection package version and improves AKS backup enablement by ensuring the required k8s-extension Azure CLI extension is available (prompting or auto-installing when --yes is used).
Changes:
- Bump version to
1.11.2and add release note. - Add
_ensure_k8s_extension()and wireyesthrough the AKS backup enablement flow. - Move prompting import to module scope and handle non-interactive sessions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/dataprotection/setup.py | Updates package version to 1.11.2. |
| src/dataprotection/azext_dataprotection/manual/aks/aks_helper.py | Adds logic to ensure/install k8s-extension and threads yes through AKS backup setup. |
| src/dataprotection/HISTORY.rst | Documents the new auto-install behavior in release notes. |
|
@FumingZhang can you please review the PR? |
|
Hi @anshulahuja98, I'm not the owner of dataprotection module |
|
Gave a minor comment. The PR looks good to me. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az dataprotection enable-backup triggerGeneral Guidelines
azdev style dataprotectionlocally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.