Skip to content

[AKS] Add Kaito preview CLI flags#6931

Merged
yanzhudd merged 2 commits into
Azure:mainfrom
helayoty:aks-ai-toolchain-operator
Feb 2, 2024
Merged

[AKS] Add Kaito preview CLI flags#6931
yanzhudd merged 2 commits into
Azure:mainfrom
helayoty:aks-ai-toolchain-operator

Conversation

@helayoty

@helayoty helayoty commented Nov 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd

azure-client-tools-bot-prd Bot commented Nov 1, 2023 •
edited
Loading

Copy link
Copy Markdown
⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_ai_toolchain_operator
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_ai_toolchain_operator
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_ai_toolchain_operator

@yonzhan

yonzhan commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

AKS

FumingZhang
FumingZhang reviewed Nov 2, 2023
View reviewed changes

@FumingZhang FumingZhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
Comment thread src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated
FumingZhang
FumingZhang reviewed Nov 2, 2023
View reviewed changes
Comment thread src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated
@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch from b9aaf9c to 464b3eb Compare November 2, 2023 06:36
@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch 5 times, most recently from 2ab0893 to e564962 Compare November 20, 2023 15:46
@yonzhan

yonzhan commented Nov 21, 2023

Copy link
Copy Markdown
Collaborator

Please fix CI issues.

@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch from e564962 to ce604dd Compare November 22, 2023 23:16
@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch from ce604dd to 4d330ee Compare December 13, 2023 04:13
@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch 5 times, most recently from e96a4e5 to fdba688 Compare January 4, 2024 20:19
FumingZhang
FumingZhang reviewed Jan 5, 2024
View reviewed changes

@FumingZhang FumingZhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change generally looks good.

Queued live test to validate the change.

Please fix failed CI checks.

@FumingZhang

FumingZhang commented Jan 5, 2024

Copy link
Copy Markdown
Member

To bypass option_length_too_long, update src/aks-preview/linter_exclusions.yml

@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch 2 times, most recently from 233a26c to ad1ab86 Compare January 5, 2024 05:01
@helayoty helayoty requested a review from FumingZhang January 5, 2024 05:27
@FumingZhang

FumingZhang commented Jan 5, 2024

Copy link
Copy Markdown
Member

The live test failed, option in update command not working as expected

@helayoty

helayoty commented Jan 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The live test failed, option in update command not working as expected

@FumingZhang Passed now. Please check the latest run.

@FumingZhang

FumingZhang commented Jan 11, 2024

Copy link
Copy Markdown
Member

Glad to see the test passed in staging env, however, staging env is not public facing, but aks-preview is. Can you wait for the server-side fix to be deployed to all regions in global cloud at least before releasing the aks-preview changes? Publishing aks-preview is on-demand and instant

https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=85538405&view=results

BTW, there's a comment tread discussing the new version naming pattern. See #7151 (comment)

@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch 3 times, most recently from df59bac to e7c6297 Compare February 1, 2024 05:23
FumingZhang
FumingZhang reviewed Feb 1, 2024
View reviewed changes

@FumingZhang FumingZhang left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Feature owner queued live test, test passed!

Comment thread src/aks-preview/HISTORY.rst Outdated
Comment thread src/aks-preview/HISTORY.rst Outdated
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch from e7c6297 to 247340d Compare February 1, 2024 06:21
FumingZhang
FumingZhang reviewed Feb 1, 2024
View reviewed changes
Comment thread src/aks-preview/HISTORY.rst Outdated
@helayoty
Add kaito preview CLI flags
698c4c6 
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty force-pushed the aks-ai-toolchain-operator branch from 247340d to 698c4c6 Compare February 1, 2024 06:36
FumingZhang
FumingZhang approved these changes Feb 1, 2024
View reviewed changes

@FumingZhang FumingZhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanzhudd
yanzhudd reviewed Feb 1, 2024
View reviewed changes
Comment thread src/aks-preview/azext_aks_preview/_help.py Outdated
@helayoty @yanzhudd
Update enable to Enable
a08f78e 
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
@yanzhudd yanzhudd merged commit 70b8109 into Azure:main Feb 2, 2024
@azclibot

azclibot commented Feb 2, 2024

Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=127156&view=results

@helayoty helayoty deleted the aks-ai-toolchain-operator branch February 2, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanzhudd yanzhudd yanzhudd approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@yonzhan yonzhan Awaiting requested review from yonzhan

@calvinhzy calvinhzy Awaiting requested review from calvinhzy

@AllyW AllyW Awaiting requested review from AllyW

@jsntcy jsntcy Awaiting requested review from jsntcy

@ReaNAiveD ReaNAiveD Awaiting requested review from ReaNAiveD

@necusjz necusjz Awaiting requested review from necusjz

@StrawnSC StrawnSC Awaiting requested review from StrawnSC

@kairu-ms kairu-ms Awaiting requested review from kairu-ms

@evelyn-ys evelyn-ys Awaiting requested review from evelyn-ys

@jiasli jiasli Awaiting requested review from jiasli

@FumingZhang FumingZhang Awaiting requested review from FumingZhang FumingZhang is a code owner

Assignees

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Milestone

October 2023 (2023-11-14)

Development

Successfully merging this pull request may close these issues.

6 participants

@helayoty @yonzhan @FumingZhang @azclibot @yanzhudd @zhoxing-ms