You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ganga1980 are you able to run the tests locally in the dev container? I believe this will help to avoid the test failures in the CI system. @devigned , I ran the tests locally. all the tests are getting passed. In-fact, I have ran "make ensure-generated" and also ran the test before pushing any code. Not sure why CI failing with mismatch in generated code.
@devigned, Thanks for pointing this. I was knocking my head why the generated files difference in CI not locally. I have ran "make reload", "make generate" and "make test", and tested my changes by creating cluster with addon. I think, this time would make the CI happy.
@devigned, Thanks for pointing this. I was knocking my head why the generated files difference in CI not locally. I have ran "make reload", "make generate" and "make test", and tested my changes by creating cluster with addon. I think, this time would make the CI happy.
@devigned , seems all the tests and checks are passed. when you get a chance, please help on merging this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
This PR has changes related updates for the Container monitoring add-on with latest agent image version: 11012019
Requirements:
Notes: