fix(policy): add Deny to managedDiskPublicNetworkAccess (#4204) - #2178
Open
Git-PrinceNagar wants to merge 1 commit into
Open
fix(policy): add Deny to managedDiskPublicNetworkAccess (#4204)#2178Git-PrinceNagar wants to merge 1 commit into
Git-PrinceNagar wants to merge 1 commit into
Conversation
…cPaaSEndpoints (#4204) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview/Summary
The
Deny-PublicPaaSEndpointsinitiative'smanagedDiskPublicNetworkAccessparameter only exposesAuditandDisabled, while the built-in policy it maps to —8405fdab-1faf-48aa-b702-999c9c172094("Managed disks should disable public network access") — also supportsDeny. As a result, customers cannot enforce (deny) public network access on managed disks via this initiative.This PR aligns the parameter with the built-in policy by adding the missing
Denyvalue.Fixes Azure/Azure-Landing-Zones#4204
This PR fixes/adds/changes/removes
DenytomanagedDiskPublicNetworkAccess.allowedValues(nowAudit,Deny,Disabled); default remainsAudit.metadata.versionfrom5.2.0to5.3.0.eslzArm/managementGroupTemplates/policyDefinitions/initiatives.jsonviabicep build.Breaking Changes
None. The change is additive and the default (
Audit) is unchanged, so existing assignments behave exactly as before —Denyis simply now selectable.Testing Evidence
Confirmed the built-in policy supports
Denyacross three independent sources:az policy definition show 8405fdab-...(live Azure)Audit, Deny, DisabledAudit, Deny, DisabledcontainerAppsPublicNetworkAccess(same file)Audit, Deny, DisabledLocal validation after the fix:
Test-BuildPolicies.Tests.ps1(build-sync gate): 3 passed / 0 failed — committedinitiatives.jsonmatches a freshbicep build.Test-ModifiedPolicies.Tests.ps1content assertions on the modified file (version bumped, category, source, cloud environments, name/filename match, parameter default): all pass.As part of this Pull Request I have
mainbranch