Skip to content

Fix issue #472#473

Merged
nayato merged 6 commits intoAzure:devfrom
yyjdelete:patch_472
Oct 21, 2019
Merged

Fix issue #472#473
nayato merged 6 commits intoAzure:devfrom
yyjdelete:patch_472

Conversation

@yyjdelete
Copy link
Contributor

@yyjdelete yyjdelete commented Apr 3, 2019

No description provided.

yyjdelete added 4 commits April 3, 2019 21:36
@yyjdelete
Align and add some missing overloads for ByteBuffer
efa4007 
Add the workaroud for case 1 in Azure#436
@yyjdelete
Remove Deque.cs from DotNetty.Common
d0bc1fb 
It used to be a part of ResourceLeakDetector, but not used anymore and not an public API of DotNetty.
@yyjdelete
Fix false positive resource leak report.
12f175f
@yyjdelete
Change some behavior of ResourceLeakDetector
1ed1646
@yyjdelete
Copy link
Contributor Author

yyjdelete commented Apr 3, 2019 •
edited
Loading

Behavior changes:

Add some missing overloads for *LeakAwareByteBuffer and WrappedCompositeByteBuffer. And remove virtual from SetUnsignedShort/SetUnsignedShortLE in AbstractByteBuffer to match other Unsigned methods, which not exists in netty. Not sure if this affacts some codes.

The last commit disable ReportLeak if no logger is available, and properly record the created place of DefaultResourceLeak, like it does in new versions of netty. And change ToString() to Dump() to make debugger happy.

@nayato nayato merged commit d4bb7ae into Azure:dev Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nayato nayato nayato approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yyjdelete @nayato