-
Notifications
You must be signed in to change notification settings - Fork 4
Unmarshal support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhzhu89
reviewed
Mar 20, 2025
azureappconfiguration.go
Outdated
Comment on lines
98
to
107
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return bytes, nil | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
directly return bytes, err?
6b7abb4 to
76c30e9
Compare
RichardChen820
approved these changes
Mar 20, 2025
jhzhu89
approved these changes
Mar 21, 2025
jhzhu89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree.goused to convert flag key value pairs into structured hierarchiesUse library mapstructure to decode
map[string]interfaceinto the proper underlying native Go structure, configured the default tag name tojsonand added hooks to convert strings to time durations and slices.