Skip to content

Conversation

@linglingye001
Copy link
Member

@linglingye001 linglingye001 commented Mar 14, 2025

tree.go used to convert flag key value pairs into structured hierarchies
Use library mapstructure to decode map[string]interface into the proper underlying native Go structure, configured the default tag name to json and added hooks to convert strings to time durations and slices.

Comment on lines 98 to 107
if err != nil {
return nil, err
}

return bytes, nil
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directly return bytes, err?

Copy link

@jhzhu89 jhzhu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linglingye001 linglingye001 merged commit d8c3c6d into release/v0 Mar 21, 2025
15 checks passed
@linglingye001 linglingye001 deleted the linglingye/unmarshal branch March 21, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants