-
Notifications
You must be signed in to change notification settings - Fork 4
Update repo documents #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20e1649 to
f39c82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the repository documentation by revising the support instructions and enhancing the README with a clearer project title, installation instructions, and examples.
- Removed outdated template text from SUPPORT.md and added a direct link for issue submission.
- Updated README.md with a more descriptive project title, installation command, and concrete examples.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SUPPORT.md | Removed placeholder instructions and added updated support information and link. |
| README.md | Revised project title, added installation instructions, and example sections. |
Files not reviewed (2)
- LICENSE: Language not supported
- NOTICE: Language not supported
Comments suppressed due to low confidence (2)
SUPPORT.md:9
- The issues link references https://github.com/Azure/AppConfiguration/issues, which may not align with the current repository for the Go Provider. Consider updating it to the correct GitHub Issues URL if applicable.
You can also open [issues](https://github.com/Azure/AppConfiguration/issues) to ask questions or share feedback about Azure App Configuration.
README.md:1
- [nitpick] Please verify that the updated project title accurately reflects the repository's scope and naming consistency, especially in relation to other references in the documentation.
# Azure App Configuration - Go Provider
README.md
Outdated
|
|
||
| > This repo has been populated by an initial template to help get you started. Please | ||
| > make sure to update the content to build a great experience for community-building. | ||
| [Azure App Configuration](https://docs.microsoft.com/en-us/azure/azure-app-configuration/overview) is a managed service that helps developers centralize their application configurations simply and securely. Go provider adds additional functionalities above the [Azure SDK for Go](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/data/azappconfig), which enables loading configuration from an Azure App Configuration store in a managed way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we copied this from the JS provider, but it gives me no idea what the go provider is about and why someone should use it. Can we rewrite?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for this, I updated the README to list supported features in v1.0.0-beta.1. This README will be continuously updated as new features are added and the quickstart docs available. Currently the go provider v1.0.0-beta.1 is ready to go public and release before this PR merged, can you help to review this PR? Thanks
README.md
Outdated
| - **Hierarchical Configuration**: Convert flat key-value pairs into nested configuration objects using customizable separators | ||
| - **Key Filtering and Prefix Management**: Selectively load configuration and remove prefixes for cleaner code | ||
| - **Automatic Key Vault Integration**: Transparently resolve Key Vault references as part of the configuration loading process | ||
| - **JSON Content Support**: Automatic parsing of JSON values into native Go types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what's this refers to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
json content type key values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, have we mentioned this feature in other providers, if not, I think we can just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
README.md
Outdated
|
|
||
| The repository includes complete examples showing how to use the Go Provider in different scenarios: | ||
|
|
||
| - [Console Application](./example/console-example/): Simple CLI app using App Configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple console app with Azure App Configuration integration
README.md
Outdated
| The repository includes complete examples showing how to use the Go Provider in different scenarios: | ||
|
|
||
| - [Console Application](./example/console-example/): Simple CLI app using App Configuration | ||
| - [Web Application](./example/gin-example/): Gin web app with App Configuration integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gin web app with Azure App Configuration integration
README.md
Outdated
|
|
||
| ## Examples | ||
|
|
||
| The repository includes complete examples showing how to use the Go Provider in different scenarios: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove. (This is by no means "complete" examples :))
README.md
Outdated
|
|
||
| ## Examples | ||
|
|
||
| - [Console Application](./example/console-example/): Simple console app with Azure App Configuration integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load settings from Azure App Configuration and use in a console application.
README.md
Outdated
| ## Examples | ||
|
|
||
| - [Console Application](./example/console-example/): Simple console app with Azure App Configuration integration | ||
| - [Web Application](./example/gin-example/): Gin web app with Azure App Configuration integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load settings from Azure App Configuration and use in a Gin web application.
README.md
Outdated
| - Updating SUPPORT.MD with content about this project's support experience | ||
| - Understanding the security reporting process in SECURITY.MD | ||
| - Remove this section from the README | ||
| Azure App Configuration Go Provider is a client library that simplifies using [Azure App Configuration](https://docs.microsoft.com/en-us/azure/azure-app-configuration/overview) in Go applications. It provides a high-level abstraction over the [Azure SDK for Go](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/data/azappconfig) that makes managing application settings easier and more intuitive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The abstraction sounds odd. Suggest below:
Azure App Configuration provides centralized configuration storage and management, allowing users to update their configurations without the need to rebuild and redeploy their applications. The App Configuration provider for Go is built on top of the Azure Go SDK and is designed to simplify data consumption in App Configuration with rich features. Users can consume App Configuration key-values as strongly-typed structs with data binding or load them into popular third-party configuration libraries, minimizing code changes. The Go provider offers features such as configuration composition from multiple labels, key prefix trimming, automatic resolution of Key Vault references, feature flags, failover with geo-replication for enhanced reliability, and many more.
README.md
Outdated
| - Remove this section from the README | ||
| Azure App Configuration Go Provider is a client library that simplifies using [Azure App Configuration](https://docs.microsoft.com/en-us/azure/azure-app-configuration/overview) in Go applications. It provides a high-level abstraction over the [Azure SDK for Go](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/data/azappconfig) that makes managing application settings easier and more intuitive. | ||
|
|
||
| ## Features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove (covered in overview).
README.md
Outdated
| - Updating SUPPORT.MD with content about this project's support experience | ||
| - Understanding the security reporting process in SECURITY.MD | ||
| - Remove this section from the README | ||
| [Azure App Configuration](https://docs.microsoft.com/en-us/azure/azure-app-configuration/overview) provides centralized configuration storage and management, allowing users to update their configurations without the need to rebuild and redeploy their applications. The App Configuration provider for Go is built on top of the [Azure Go SDK](https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/data/azappconfig) and is designed to simplify data consumption in App Configuration with rich features. Users can consume App Configuration key-values as strongly-typed structs with data binding or load them into popular third-party configuration libraries, minimizing code changes. The Go provider offers features such as configuration composition from multiple labels, key prefix trimming, automatic resolution of Key Vault references, feature flags, failover with geo-replication for enhanced reliability, and many more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop /en-us from the link: https://docs.microsoft.com/azure/azure-app-configuration/overview
No description provided.