fix: remove obsolete KZG:masking_challenge from batched translator expected manifest#21371
Merged
iakovenkos merged 1 commit intomerge-train/barretenbergfrom Mar 11, 2026
Conversation
…pected manifest The KZG opening protocol no longer sends a masking_challenge (removed in #21040). The ProverManifestConsistency test's expected manifest was not updated, causing a mismatch in round 26.
iakovenkos
approved these changes
Mar 11, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
BEGIN_COMMIT_OVERRIDE chore: Native curve audit - pairing (#21104) feat: batch hiding kernel and translator proofs (#21246) fix: remove obsolete KZG:masking_challenge from batched translator expected manifest (#21371) fix: add TLS alignment pad to fix x86_64-macos segfault (#21372) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
BatchedHonkTranslatorTests.ProverManifestConsistencytest was failing because its hardcoded expected manifest included aKZG:masking_challengeentry in round 26 (the KZG opening round), but the KZG protocol no longer sends this challenge (removed in #21040).Fix
Removed the stale
m.add_challenge(round, "KZG:masking_challenge")frombuild_expected_batched_manifest()and updated the corresponding comment.Test plan
BatchedHonkTranslatorTests.ProverManifestConsistencypassesbatched_honk_translator_testspass locallyClaudeBox log: https://claudebox.work/s/a26a429f5a7f3d3d?run=1