fix(center-stage): zoom in on far subjects (per-framing min crop floor)#124
Merged
Conversation
Center Stage didn't crop tightly enough on a distant subject: the crop's lower size bound (min_frac) was a fixed 0.34 of the frame for every framing, so a far person's natural tight crop (subject_height / fill) was floored back out and the person stayed small. min_frac is now per-framing in _CENTERSTAGE_FRAMING: face 0.12 / head_shoulders 0.16 / upper_body 0.22 / full_body 0.34 — closer framings allow a tighter zoom so a far face/upper-body genuinely fills the crop, while full_body stays conservative. Over-zoom on true specks is still prevented upstream by tracking.min_detection_size_frac. tests/test_digital_framer.py: far-subject zoom + framing-floor ordering. Note: the companion bug (overlay detection/track boxes not transformed into the cropped preview's coordinate space) is a separate telemetry+UI change, tracked as a follow-up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Center Stage, a subject far from the camera wasn't cropped tightly enough — they stayed small in the frame. The crop's minimum size (
min_frac) was a fixed 0.34 of the frame for all framings, so a far person's natural tight crop (subject_height / fill) got floored back out.Fix
min_fracis now per-framing in_CENTERSTAGE_FRAMING: face 0.12 · head_shoulders 0.16 · upper_body 0.22 · full_body 0.34. Closer framings allow a tighter zoom so a far face / upper-body actually fills the crop;full_bodystays conservative. True specks are still dropped upstream bytracking.min_detection_size_frac, so a low floor is safe.Tests added for far-subject zoom + the framing-floor ordering.
Follow-up (separate PR): overlay detection/track boxes aren't yet transformed into the cropped preview's coordinate space (bug #2 from the report) — needs a telemetry crop-rect field + UI transform.
🤖 Generated with Claude Code