Make audius_discprov_url required and add blurb about logging#50
Conversation
|
|
||
| logspout: | ||
| image: audius/logspout:v3.2.14 | ||
| image: audius/logspout:v3.2.14-disable-logging |
There was a problem hiding this comment.
This will get created when this PR is merged AudiusProject/apps#3672
There was a problem hiding this comment.
This tag looks like it's trying to indicate that this image has logging disabled.
Could we use something like a hash perhaps? (Maybe just off latest master?) Something that doesn't say "disable" in it would be ideal.
The sister PR also looks good, save for this one matching change. 🎉
There was a problem hiding this comment.
good call. how about we call it like v3.2.14-update-1? this also follows some conventional naming standards
There was a problem hiding this comment.
Nice! I like that direction more!
How about v3.2.14-1, which seems more canonical and matches homebrew and some apt packages' version styling?
Make audius_discprov_url required so both content and discovery node have a url that can be associated with the logs in the logging service. In addition add documentation about disabling logging