add audius_ddex_apps envvar#481
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 2416686 | Triggered | Generic High Entropy Secret | 7206770 | discovery-provider/stage.env | View secret |
| 2460751 | Triggered | Generic High Entropy Secret | 7206770 | discovery-provider/prod.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
theoilie
left a comment
There was a problem hiding this comment.
rather than add an env var to every discovery node, why don't we use existing db data?
- to verify an app's existence:
select * from "developer_apps" where address = '0x<ddex_key>' - to verify userId has delegated write permission to an app:
select * from "grants" where user_id = '<decoded_id>' and grantee_address = '0x<ddex_key>' and is_revoked=f and is_current=t and is_approved=t
There was a problem hiding this comment.
maybe i misunderstood. this env var list is just to differentiate between a ddex app and a non-ddex app? that makes sense so maybe we leave it for now, but long-term it would mean any third party running a DDEX app would need to make a code change.
the first alternative that comes to mind is making the app creation UI have a checkbox for "is DDEX" which corresponds to a column in the developer_apps table for us to reference when indexing cc @nicoback2
edit: i should've read the other PR first. looks like you're already thinking of doing this here, nice!
yeah my bad for no context - explanation in the other PR |
Description