Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[PAY-1127] Improve mobile chats performance: remove index dep#3170

Merged
dharit-tan merged 4 commits into
mainfrom
rt-perf
Apr 6, 2023
Merged

[PAY-1127] Improve mobile chats performance: remove index dep#3170
dharit-tan merged 4 commits into
mainfrom
rt-perf

Conversation

@dharit-tan

@dharit-tan dharit-tan commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

Description

Improves performance by removing the dependency on index so we can memoize ChatMessageListItem. We calculate hasTail in the slice now, and use message ids instead of indices for the earliestUnreadIndex comparison. Also includes a few other optimizations.

Todo: use reselect for 2 new selectors. Will follow up with another commit tmr.

Notes:

  • @dylanjeffers may still be right that reversing the index order makes more sense, but it's good to remove the dependency on index either way. One thing we do get from this ordering is new messages coming in at the bottom instead of top (when starting from fresh chat).
  • Seems like we should be able to get the CellRenderer to not re-render as well, but this is probably good enough for now.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Local ios stage, confirmed ChatMessageListItem is successfully memoized!

Screenshot 2023-04-04 at 10 46 14 PM

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

dylanjeffers
dylanjeffers approved these changes Apr 5, 2023
View reviewed changes

@dylanjeffers dylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job

Comment thread packages/mobile/src/screens/chat-screen/ChatMessageListItem.tsx Outdated
Comment thread packages/mobile/src/screens/chat-screen/ChatScreen.tsx Outdated
Comment thread packages/common/src/models/Chat.ts
sddioulde
sddioulde approved these changes Apr 5, 2023
View reviewed changes

@sddioulde sddioulde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general. left a few comments

Comment thread packages/common/src/store/pages/chat/slice.ts
Comment thread packages/common/src/store/pages/chat/slice.ts
Comment thread packages/mobile/src/screens/chat-screen/ChatMessageListItem.tsx Outdated
Comment thread packages/mobile/src/screens/chat-screen/ChatScreen.tsx
Comment thread packages/mobile/src/screens/chat-screen/ChatScreen.tsx
@dharit-tan dharit-tan merged commit 0559902 into main Apr 6, 2023
@dharit-tan dharit-tan deleted the rt-perf branch April 6, 2023 17:04
audius-infra pushed a commit that referenced this pull request Apr 8, 2023
v1.5.19
33f8cbe 
[eb23ea0] [C-2309] Fix track title hover state (#3197) Dylan Jeffers
[b82a6ee] [C-2303] Ensure consistent play/active state for entity tiles (#3195) Dylan Jeffers
[3faedfb] [C-2223] Flex on Finnuh (#3196) Raymond Jacobson
[d1cd884] [C-2271] Update data passed to edit playlist form to update playlist properly (#3183) Kyle Shanks
[7837460] [C-2187] Improve sign-up error messages (#3194) Dylan Jeffers
[e200477] [C-2287] Update wallet connect language, flags, icons (#3192) Dylan Jeffers
[cc0b56d] allow create notification to handle playlist id as array or int (#3190) sabrina-kiam
[d357b3b] [C-2431] Add tastmaker notification to mobile (#3191) Dylan Jeffers
[83a6d36] No playlists text fix C-2296 (#3189) nicoback2
[0e44281] [PLAT-847]: Fix user subscription create album notification copy (#3162) sabrina-kiam
[7da3e10] [C-2412] Opaque id deeplinks (#3188) Sebastian Klingler
[4ff1c53] [C-2418] Fix mobile web open in app banner (#3173) Raymond Jacobson
[22a1240] [C-1504] Prevent user from following themselves (#3187) Dylan Jeffers
[465182a] [C-2306] Fix sign-in sign-up invalid email bug (#3186) Dylan Jeffers
[2cec764] [C-1750] Refactor top tags (#3180) Dylan Jeffers
[7ca864f] Fix Snap sharing with weird track names C-2081 (#3176) nicoback2
[761187a] Fix missing track on Sammie's page C-2342 (#3182) nicoback2
[41c9cf5] Fix track upload cover art name (#3138) Theo Ilie
[cfb0b96] [C-2428] Handle null in cache map handle/permalink adds (#3184) Andrew Mendelsohn
[0559902] [PAY-1127] Improve mobile chats performance: remove index dep (#3170) Reed
[961649a] Use RNGH touchables for mobile chats (#3174) Reed
[be5d2a5] [C-2427] Fix preinstall checks for ruby and python versions (#3179) Andrew Mendelsohn
[48f8d4c] Update readme with deps, remove sudo (#3178) Reed
[fe79400] Disallow sharing premium content to social media, remove feature flags C-2334 C-2420 (#3172) nicoback2
[776596f] [PAY-829][PAY-1044] Desktop: Chats search users modal permissions/blocks and profile page permissions/blocks (#3156) Marcus Pasell
[e4df304] Fix scrolling on ChatListScreen (#3171) Reed
[6f35699] [PAY-1041][PAY-1040][PAY-1126] Mobile search users screen improvements (#3159) Reed
[d9e302b] [PAY-1143] Desktop: Overflow menu on Chat Header (#3169) Marcus Pasell
[798a664] Fix edit profile button not working after you submit the first time (#3163) nicoback2
[1d78774] [PLAT-814] Use sdk discovery-node-selection in libs (#3125) Dylan Jeffers
[58005c4] [PAY-799] DMs: Link previews (#3096) Marcus Pasell
[7e3d44c] [PAY-924][Desktop] DMs: Blocking/Unblocking Wire Up/UI (#3155) Marcus Pasell
[7038d81] [C-2347] Improve popover zIndex (#3168) Dylan Jeffers
[3eb62fe] [C-2364] Fix missing artist-card badges on android (#3165) Dylan Jeffers
[64ffb7f] Update @audius/sdk to 2.0.3-beta.4 (#3160) Marcus Pasell
[6e5306c] [QA-443] Fix cache case matching for handles and permalinks (#3167) Andrew Mendelsohn
[84dcb5a] [C-2059] Show toast when email check fails due to blocked user (#3166) Sebastian Klingler
[be855a4] [C-2419] Fix offline lineup loading (#3164) Andrew Mendelsohn
[920e25b] Fix permissions message for adding to photos C-2379 (#3161) nicoback2
[78cbdfa] [PLAT-819]: Fix copy for repost and save of albums notifications (#3151) sabrina-kiam
[10617a2] Mobile chats use push instead of navigate (#3154) Reed
[6131075] [C-2406] Fix repeated edits of same track (#3157) Sebastian Klingler
[3ae27d1] Mobile chats scrolling improvements (#3153) Reed
[e820e3f] [C-2336, C-2388] Playlist style and bug fixes (#3149) Kyle Shanks
[955887f] [C-2406] Null check localStorage (#3150) Sebastian Klingler
[3b31b73] [C-2227] Clear wallet state on sign-out (#3147) Dylan Jeffers
[91940fb] [C-2406] Prevent non finite set of currentTime (#3148) Sebastian Klingler
[d799e30] [C-2404] Fix ios build on xcode 14.3 (#3146) Dylan Jeffers
[186a086] [C-2398] Clean up playlist-update feature flags (#3145) Dylan Jeffers
[edb3142] update to xcode 14.2.0 (#3107) Raymond Jacobson
[4add953] [PLAT-835] Fix tastemaker twitter button (#3144) Dylan Jeffers
[e68ada9] [PLAT-834]: Fix notifications last seen new tag (#3143) sabrina-kiam
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rickyrombo rickyrombo Awaiting requested review from rickyrombo
@piazzatron piazzatron Awaiting requested review from piazzatron
@dylanjeffers dylanjeffers Awaiting requested review from dylanjeffers
1 more reviewer
@sddioulde sddioulde sddioulde approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@piazzatron piazzatron

@sddioulde sddioulde

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dharit-tan @dylanjeffers @sddioulde @piazzatron