This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Fix artist pick reads from discovery#2794
Closed
michellebrier wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Combining with #2795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noticed reading artist pick from discovery wasn't working when viewing other people's profiles. This was because we had added this line manually pruning the artist pick field when fetching and caching the user's metadata sometime between now and when I initially added the flag in. Does not affect viewing one's own profile because that info is fetched and cached in
getAccountinAudiusBackend.ts.Going to hotfix this change onto the 1.5.9 release so that we can turn on reads then delete the legacy identity path for artist pick in the next client release.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.