Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[PAY-777] Add premium content track upload on mobile - Part 1#2707

Merged
sddioulde merged 12 commits into
sd-pc-track-upload-mobile-2from
sd-pc-track-upload-mobile
Jan 31, 2023
Merged

[PAY-777] Add premium content track upload on mobile - Part 1#2707
sddioulde merged 12 commits into
sd-pc-track-upload-mobile-2from
sd-pc-track-upload-mobile

Conversation

@sddioulde

@sddioulde sddioulde commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

Description

First part in a series of PRs that will end up with premium track upload being a feature on mobile.

Merges into #2722

Dragons

Has to do with track upload which is a critical part of the app.

How Has This Been Tested?

Local mobile app against stage and against prod.

How will this change be monitored?

N/A

Feature Flags

Existing premium content feature flags, including the ios and android feature flags.

@sddioulde
sddioulde marked this pull request as draft January 27, 2023 14:30
@sddioulde
sddioulde force-pushed the sd-pc-track-upload-mobile branch from 24d9ae7 to 7f267e8 Compare January 27, 2023 14:44
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-mobile

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-mobile

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-mobile

@sddioulde sddioulde changed the title WIP [PAY-777] Add premium content track upload on mobile - Part 3 Jan 27, 2023
@sddioulde sddioulde changed the title [PAY-777] Add premium content track upload on mobile - Part 3 [PAY-777] Add premium content track upload on mobile - Part 1 Jan 27, 2023
@sddioulde
sddioulde changed the base branch from main to sd-pc-track-upload-mobile-2 January 27, 2023 23:22
@sddioulde
sddioulde marked this pull request as ready for review January 27, 2023 23:28
Comment thread packages/mobile/src/screens/edit-track-screen/screens/NFTCollectionsScreen.tsx Outdated

@piazzatron piazzatron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good - let's make sure we pull out any shared complex NFT filtering logic into a memoized selector for web + mobile to both use! Epic PR day :D

Also, maybe you can powow with @dylanjeffers briefly next week as well around Formik use, I wonder if there's a way we can avoid having to manually type all of these calls?

Comment thread packages/mobile/src/screens/edit-track-screen/screens/NFTCollectionsScreen.tsx Outdated
Comment thread packages/mobile/src/screens/edit-track-screen/screens/TrackAvailabilityScreen.tsx Outdated
Comment thread packages/mobile/src/screens/edit-track-screen/screens/NFTCollectionsScreen.tsx Outdated

@rickyrombo rickyrombo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Dylan and Piazza's comments, I think we could extract some of the useMemo logic stuff to selectors

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-mobile

@sddioulde
sddioulde merged commit ea60dd6 into sd-pc-track-upload-mobile-2 Jan 31, 2023
@sddioulde
sddioulde deleted the sd-pc-track-upload-mobile branch January 31, 2023 21:38
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants