This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Update ArtistChip and ArtistChipTips#2702
Merged
Merged
Conversation
- separate out types of support - send the user ids to compare via props rather than pulling from store
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepare
ArtistChipso that it can be used in theSearchUsersModalArtistChipstyles that isn't necessary as theUserListis the only consumerArtistChipTipsto be usable outside of the context of aUserListshowPopoverbehavior forArtistChipto be respected byArtistIdentifierin addition to the profile picDragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
This is a a pretty significant refactor of
UserListandArtistChip. Will need testing on Supporter/Supporting user lists for sureHow Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested locally on stage against supporter/supporting user lists
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.