Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[PAY-817] Add premium content to track upload flow on desktop - Part 2#2546

Merged
sddioulde merged 30 commits into
mainfrom
sd-pc-track-upload-flow
Jan 13, 2023
Merged

[PAY-817] Add premium content to track upload flow on desktop - Part 2#2546
sddioulde merged 30 commits into
mainfrom
sd-pc-track-upload-flow

Conversation

@sddioulde

@sddioulde sddioulde commented Jan 9, 2023

Copy link
Copy Markdown
Contributor

Description

Continuation of #2469 to add premium content track upload on web.

Dragons

Part of track upload. Critical.

How Has This Been Tested?

Upload different types of tracks:

  • public
  • hidden
  • collectible gated
  • follow gated
  • tip gated

How will this change be monitored?

N/A

Feature Flags

premium_content-enabled, special_access_enabled, nft_gate_enabled

Comment thread packages/common/src/store/collectibles/reducer.ts Outdated
@sddioulde sddioulde force-pushed the sd-pc-track-upload-flow branch from 0744f3c to e259070 Compare January 10, 2023 02:42
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

@sddioulde sddioulde changed the title [PAY-776] Add premium content to track upload flow on desktop - Part 2 [PAY-817] Add premium content to track upload flow on desktop - Part 2 Jan 10, 2023
@sddioulde sddioulde requested a review from rickyrombo January 10, 2023 16:19
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

@sddioulde sddioulde force-pushed the sd-pc-track-upload-flow branch from d1a999e to 54ef726 Compare January 10, 2023 16:48
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

Comment thread packages/common/src/services/solana-client/SolanaClient.ts
Comment thread packages/common/src/store/reducers.ts Outdated
Comment thread packages/web/src/common/store/profile/sagas.js
Comment thread packages/web/src/components/data-entry/DropdownInput.js Outdated
Comment thread packages/web/src/pages/upload-page/UploadPage.js Outdated

@piazzatron piazzatron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! A few UI things I found in playing around with it:

  • The radio buttons themselves aren't clickable, just the rows

Screen Shot 2023-01-10 at 5 32 28 PM

- The Collectible Gated Dropdown doesn't have any zero state for when you have no collectibles - it tells you to pick a collection, even if you don't have collections. Let's confer with design and see how we want to handle this case

Screen Shot 2023-01-10 at 5 34 25 PM

Comment thread packages/common/src/store/collectibles/slice.ts
Comment thread packages/common/src/store/reducers.ts Outdated
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

@sddioulde sddioulde force-pushed the sd-pc-track-upload-flow branch from 7a0f846 to d875be3 Compare January 12, 2023 20:19
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/sd-pc-track-upload-flow

@sddioulde sddioulde merged commit 2d9a92f into main Jan 13, 2023
@sddioulde sddioulde deleted the sd-pc-track-upload-flow branch January 13, 2023 00:26
audius-infra pushed a commit that referenced this pull request Jan 14, 2023
[646a2ee] [C-1772] Fix share-drawer for tracks with missing images (#2594) Dylan Jeffers
[ea615c6] [C-1829] Fix android build due to gradle dep (#2592) Dylan Jeffers
[708563a] [C-1778] Fix update banner styles (#2591) Dylan Jeffers
[aa51116] update playlist_page route to accept permalink optionally (#2569) sabrina-kiam
[8ed8846] Move stream mp3 feature flag check later so optimizely is ready (#2590) Andrew Mendelsohn
[8c19e15] [PAY-778] Update track page for premium tracks (#2565) Saliou Diallo
[9bc901e] [C-1643] Update track player to work with the queue in the redux store (#2580) Kyle Shanks
[6e9c2d1] Make rc-staging fast-app variant (#2585) Dylan Jeffers
[c75163a] Fix notification userInteraction (#2583) Dylan Jeffers
[2d9a92f] [PAY-817] Add premium content to track upload flow on desktop - Part 2 (#2546) Saliou Diallo
[e9b0673] [C-1821] Fix android manual sign up overflow (#2582) Sebastian Klingler
[c26a6c4] Add null check for notification navigation hook (#2581) Kyle Shanks
[b62a866] Entity manager notification writes (#2556) Joseph Lee
[b685c89] [C-1819] Fix customCheck in waitForValue (#2578) Sebastian Klingler
[4ddbd37] Bump ios to 1.1.52 (#2577) Sebastian Klingler
[70a9fd5] [C-1816] Fix divider color (#2574) Sebastian Klingler
[0796f47] Hotfix: Fix mobile build after selector was changed (#2575) Marcus Pasell
[0d513a7] DMs UI Part 1 (#2563) Marcus Pasell
[0e24bbc] [C-1726] useLocalImage (#2564) Sebastian Klingler
[6329be8] [C-1815] Fix legacy image loading (#2573) Sebastian Klingler
[57d72ab] [C-1814] Prevent infinite rerender of UserList (#2572) Sebastian Klingler
[b3b00e8] [C-1706] Fix sidebar track statistic (#2570) Dylan Jeffers
[abb17ef] Fix setup states (#2567) Raymond Jacobson
[c9f158e] Remove EntityManager gating for users and tracks (#2549) Isaac Solo
[adea3ff] [C-1760] Fix lineup-tile animation lag (#2548) Dylan Jeffers
[3c3426d] [C-1791] Add fast-cache, safe-fast-cache (#2554) Dylan Jeffers
[15b26fd] [C-1764] Fix offline app initialization for offline mode (#2560) Andrew Mendelsohn
[bd9ab4d] [C-1790] Improve lottie colorize perf (#2552) Dylan Jeffers
[120cce4] [C-1397] Add appVersion to optimizely audience attributes (#2561) Sebastian Klingler
[32962ec] Bump ios to 1.1.51 (#2558) Sebastian Klingler
[bd40d44] [QA-282] Fix app crash on edit playlist screen when missing collection image source (#2559) Kyle Shanks
[ee0e3cd] Update the feature flag for rate cta drawer (#2557) Kyle Shanks
[c0c12d7] Add back arm64 exclusion (#2531) Marcus Pasell
[7287c4c] [PAY-803] [PAY-766] Initial DMs client integration (#2521) Marcus Pasell
[effd347] [PAY-367] [C-1786 C-1661] Refactor FeedTipTile/Lineup interdependency (#2547) Dylan Jeffers
[6eb31a8] [PAY-808] [PAY-810] Float new playlists to top of library (#2526) Michael Piazza
[9c133b5] [C-1789] Fix lottie colorize crash (#2551) Sebastian Klingler
[a27b24d] [C-1418] Add new android bundles (#2523) Sebastian Klingler
[12dd5e8] [C-1788][C-1784][C-1785] Fix offline queue loops and duplicates (#2550) Andrew Mendelsohn
[fc4c8d2] [C-1779 Improve makeStyles performance (#2541) Dylan Jeffers
[08b79bc] [C-1766][C-1781] Fix loading states on DownloadToggle (#2545) Andrew Mendelsohn
[470a44f] [C-1756][C-1767] Fix job cancellation for track download queue (#2543) Andrew Mendelsohn
[bd15357] [C-1703] fix button padding for remove download playlist (#2544) Andrew Mendelsohn
[6eb6b74] [PAY-776] Add premium content to track upload flow on desktop - Part 1 (#2469) Saliou Diallo
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants