[PAY-651][PAY-613] Add Stripe Provider to On Ramps by rickyrombo · Pull Request #1950 · AudiusProject/audius-client

rickyrombo · 2022-09-19T23:39:41Z

Description

Adds Stripe as a provider to the on ramp enum
Adds an action/selector to set/get the on ramp provider
Create an OnRampButton instead of CustomCoinbaseButton that's shared between stripe/coinbase
Fix dark mode/matrix mode for the OnRampButton
Add proper memo for on ramps that use Stripe
Use correct provider string for metrics
Add a new modal to display Stripe UI in

NOTE: Does not actually call new libs method yet, depends on AudiusProject/apps#3878

TODO:

Update libs once [PAY-645] Add a route to start a stripe session in SDK apps#3878 is in
Implement createStripeSession in audius-backend/BuyAudio.ts
Code to handle completing Stripe onramp
Add Stripe API key to config somewhere (waiting to see if docker-compose stuff will go in first to avoid conflicts)

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Couldn't test E2E yet, due to issues in Stripe API, but UI looks good so far

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Added provider to the amplitude logs

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

All behind BUY_AUDIO_ENABLED

audius-infra · 2022-09-20T19:39:50Z

Preview this change https://demo.audius.co/mjp-stripe-provider

gitguardian · 2022-09-21T00:31:57Z

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
2858199	Generic High Entropy Secret	`eb3cc2e`	packages/mobile/.env.dev.tmpl	View secret
2858198	Generic High Entropy Secret	`eb3cc2e`	packages/mobile/.env.prod.tmpl	View secret
2858199	Generic High Entropy Secret	`eb3cc2e`	packages/mobile/.env.stage.tmpl	View secret
2858198	Generic High Entropy Secret	`afdf2db`	packages/web/.env/.env.prod	View secret
2858199	Generic High Entropy Secret	`afdf2db`	packages/web/.env/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

audius-infra · 2022-09-21T17:08:27Z

Preview this change https://demo.audius.co/mjp-stripe-provider

sddioulde

nice!

waiting for todos to complete before approving

piazzatron

LGTM!

rickyrombo · 2022-09-26T17:16:57Z

Gonna save remaining TODOs for a followup PR

audius-infra · 2022-09-26T18:27:48Z

Preview this change https://demo.audius.co/mjp-stripe-provider

audius-infra · 2022-09-28T01:30:22Z

Preview this change https://demo.audius.co/mjp-stripe-provider

[287f114] [C-1179] Fix edit-profile (#2048) Dylan Jeffers [65456c9] [C-1207] Fix stem downloads (#2041) Dylan Jeffers [aa7183c] Fix duplicate playlists once playlist is confirmed / Await feature flag response in sagas C-1199 (#2044) nicoback2 [2340604] [C-1208] Track playback UID is not consistent when clicking into track (#2046) Sebastian Klingler [b300cba] Add premium content default fields to track upload (#2042) Saliou Diallo [e80e0bb] [PAY-655] Refactor challenges config, fix bugs (#2016) Michael Piazza [86d4741] [C-1206] double check before declaring offline state (#2034) Andrew Mendelsohn [69ccfac] Upgrade sdk 1.0.8 (#2040) Isaac Solo [3c8ac81] Fix image uploads in new native (#2019) nicoback2 [e0faae7] Fix tracks/reposts lineups for artist with handles with capitials (#2039) Dylan Jeffers [32b472b] [C-481] Fix profile header loading jank (#2038) Dylan Jeffers [7e3a4c6] [C-1128] Add profile screen skeleton (#2037) Dylan Jeffers [e3390af] Improve navigation perf related to drawer context (#2036) Dylan Jeffers [9a12d48] Fix profile reposts loading issue (#2035) Dylan Jeffers [544b01e] [C-1065][C-1066] Primitive download and playback for tracks offline (#2021) Andrew Mendelsohn [d335a31] User entity manager (#2017) Joseph Lee [522f044] Disable dominant color on mobile (#2031) Sebastian Klingler [c3093a6] Add AudioTransactionsIcon component (#2030) Kyle Shanks [c31d1b2] Fix some tests c-1140 (#1966) nicoback2 [575caad] [C-1197] Custom skeleton for feed tip tile (#2027) Raymond Jacobson [8399ee1] fix new playlist made from track - invalid date (#2029) nicoback2 [3971aaf] [C-1154] Deep linking (#2023) Sebastian Klingler [fcaf65a] [C-1195] Fix image loading in image hooks (#2025) Dylan Jeffers [6f54ba1] [C-1194] Fix desktop profile state (#2022) Dylan Jeffers [3044ded] Fix navigation context scope and setting (#2026) Dylan Jeffers [4c8bb56] [C-1092] Implement eager load utils in mobile (#2002) Raymond Jacobson [37048f6] Fix static server crash (#2024) Sebastian Klingler [4d7bd27] Add entity manager address to dev (#2013) Isaac Solo [d77ee2d] Fix feeling lucky typecheck (#2020) Isaac Solo [e83d105] Update feeling lucky to not rely on latest track (#1954) Isaac Solo [af72734] Add new table for Artist Dashboard (#2018) Kyle Shanks [f3f8abb] [C-1177] Move tipping requests to api client (#1995) Raymond Jacobson [b2b986d] [C-1170] Optimistically add/remove reposted tracks/collections (#2009) Dylan Jeffers [0fda0b8] [PAY-651][PAY-613] Add Stripe Provider to On Ramps (#1950) Marcus Pasell [5cb01d0] [C-1181] skip connection check if not in foreground (#2010) Andrew Mendelsohn [254f42e] [C-1157] Fix remix icon position (#2014) Dylan Jeffers [33b10ee] [C-1164] Fix collections screen loading issues (#2005) Dylan Jeffers [9c1c1ce] Cast port to number (#2015) Sebastian Klingler [d656b0a] Upgrade sdk 1.0.6 (#2012) Isaac Solo [9e5dfef] Fix static server error (#2011) Sebastian Klingler [42aa891] Hardcode web-sync static-server port (#2008) Dylan Jeffers [9a106c3] Remove more webview instructions from readme (#2007) Sebastian Klingler [d68aa89] Omit creator_node_endpoint when updating metadata via collectible fetch (#2006) Sebastian Klingler [8b16e7f] Use .env.dev instead of .env.dev.local (#2004) Raymond Jacobson [82864e0] Fix start:dev command (#2003) Raymond Jacobson [1661b77] [C-1150, C-1165] Fix app-tab navigation (#2001) Dylan Jeffers [8235eb0] [INF-180] Update client for new compose local dev (#1577) Raymond Jacobson [71d1e92] [C-1167,C-1171] Fix missing tip data (#2000) Dylan Jeffers [1c3d609] [C-1156, C-1055, C-1159] Fix profile follow button (#1999) Dylan Jeffers [2005467] [C-1174] Fix blank listening history screen (#1998) Dylan Jeffers [42945e3] Remove tmpl env vars (#1997) Raymond Jacobson [f637ded] [C-1173] Reintegrate WebAppAccountSync (#1996) Dylan Jeffers [b11f04d] [C-1176] Improve ExploreScreen performance (#1994) Dylan Jeffers [f6680c5] [C-536] Cache makeStyles StyleSheets (#1993) Dylan Jeffers

rickyrombo added 13 commits September 15, 2022 22:10

Add BuyAudio provider action/selector

6f964dc

Create OnRampButton

fc0110d

Neutral instead of white for dark mode/matrix mode

6b65aae

Consume new OnRampButton and add to wallet management tile

99420bb

Remove old custom coinbase button component

564e843

Make stripe button grow less

01b6a57

Remove extraneous reference to custom coinbase button

9bb0ec8

Update InputPage + CoinbaseBuyAudioButton to use selectors internally

0bd0395

Add stripe packages to index for now

073da5a

Update sagas to use Stripe provider

5a6a8b4

Add stripe on ramp modal

7a7bdf4

Create Stripe Session

dafa4bf

Add stripe buy audio button

0a30cbe

pull-request-size Bot added the size/XL label Sep 19, 2022

rickyrombo assigned dharit-tan, piazzatron and sddioulde Sep 19, 2022

rickyrombo changed the title ~~Add Stripe Provider to On Ramps~~ [PAY-651][PAY-613] Add Stripe Provider to On Ramps Sep 19, 2022

rickyrombo added 3 commits September 19, 2022 19:18

Put both providers inline on the rewards page

0ed2333

Don't disable stripe button on modal open

f64ec09

Disable libs call for now

5483a90

rickyrombo marked this pull request as ready for review September 20, 2022 19:18

Use backend BuyAudio.ts

7c8b16f

This was referenced Sep 20, 2022

[PAY-568] Add route to identity to create a Stripe session AudiusProject/apps#3879

Merged

[PAY-645] Add a route to start a stripe session in SDK AudiusProject/apps#3878

Merged

Merge remote-tracking branch 'origin/main' into mjp-stripe-provider

eb3cc2e

rickyrombo added 2 commits September 20, 2022 17:47

Test signing

cc8379c

Fix button

29582a1

sddioulde previously approved these changes Sep 21, 2022

View reviewed changes

Comment thread packages/web/src/components/buy-audio-modal/components/AmountInputPage.tsx

Comment thread packages/web/src/components/buy-audio-modal/components/StripeBuyAudioButton.tsx

sddioulde self-requested a review September 21, 2022 17:58

piazzatron approved these changes Sep 26, 2022

View reviewed changes

Comment thread packages/web/src/components/stripe-on-ramp-modal/StripeOnRampModal.module.css

Comment thread packages/web/src/pages/audio-rewards-page/components/WalletManagementTile.tsx

rickyrombo added 2 commits September 26, 2022 10:10

Add env var for stripe publishable key

afdf2db

Use selector internally instead of passing props

d0d1f41

Woops missed the import

0ee0945

rickyrombo added 2 commits September 27, 2022 16:12

Merge remote-tracking branch 'origin/main' into mjp-stripe-provider

e4fccb7

Merge remote-tracking branch 'origin/main' into mjp-stripe-provider

d975868

rickyrombo merged commit 0fda0b8 into main Sep 28, 2022

rickyrombo deleted the mjp-stripe-provider branch September 28, 2022 01:49

AudiusProject deleted a comment from linear Bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[PAY-651][PAY-613] Add Stripe Provider to On Ramps#1950

[PAY-651][PAY-613] Add Stripe Provider to On Ramps#1950
rickyrombo merged 25 commits into
mainfrom
mjp-stripe-provider

rickyrombo commented Sep 19, 2022 •

edited

Loading

Uh oh!

audius-infra commented Sep 20, 2022

Uh oh!

gitguardian Bot commented Sep 21, 2022 •

edited

Loading

Uh oh!

audius-infra commented Sep 21, 2022

Uh oh!

sddioulde left a comment

Uh oh!

Uh oh!

Uh oh!

piazzatron left a comment

Uh oh!

Uh oh!

Uh oh!

rickyrombo commented Sep 26, 2022

Uh oh!

audius-infra commented Sep 26, 2022

Uh oh!

audius-infra commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

rickyrombo commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

Uh oh!

audius-infra commented Sep 20, 2022

Uh oh!

gitguardian Bot commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Sep 21, 2022

Uh oh!

sddioulde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

piazzatron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rickyrombo commented Sep 26, 2022

Uh oh!

audius-infra commented Sep 26, 2022

Uh oh!

audius-infra commented Sep 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rickyrombo commented Sep 19, 2022 •

edited

Loading

gitguardian Bot commented Sep 21, 2022 •

edited

Loading