This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Fix eager discovery loader#1737
Merged
Merged
Conversation
dylanjeffers
approved these changes
Aug 18, 2022
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
sweet so basically try cached, if not get from env?
Member
Author
Yep! |
Collaborator
|
Preview this change https://demo.audius.co/rj-fix-eager-loader |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eager loader is returning early if no cached value. Instead we should pull from the env vars set in the .env file.
Observed behavior is when you load localhost:3001/df/playlist/probers_playlist_do_not_delete-511 in incognito for the first time, it would crash b/c we can't initialize API client w/o some discovery node.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Locally w/ probers
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.