This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-531] Fix become first supporter bug#1735
Merged
Merged
Conversation
Contributor
Author
|
What i really want, is dispatch the action within the hook so that consuming components dont have to all be touched. for now only the SendTipScreen component cares, but if we decided to directly open the tip modal for web, then the SendTip component would also need to be updated. |
sddioulde
commented
Aug 17, 2022
added 2 commits
August 17, 2022 19:23
Collaborator
|
Preview this change https://demo.audius.co/sd-pay-531 |
dharit-tan
approved these changes
Aug 18, 2022
piazzatron
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Fix become first supporter bug * Remove comments * Fix lint from root * Remove unnecessary account var * Update comment Co-authored-by: Saliou Diallo <saliou@audius.co>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This bug is new because it's now possible to tip a user without going to their profile and without clicking from the feed tip tile. The bug is because the receiver's supporters weren't fetched and so the UI thinks there is no supporter for the user.
So the fix is to fetch that user i.e. the receiver's supporters.
=====
I think this change will make sure that the account and receiver's necessary supporting / supporters exist, so if there is another UI flow that goes into tipping in the future, we'd still be okay.
first.supporter.bug.fix.mov
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
mobile against local dapp pointing to prod
How will this change be monitored?
n/a
Feature Flags
none