This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-842] Add scrypt and account sagas to mobile#1730
Merged
Conversation
dylanjeffers
suggested changes
Aug 17, 2022
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
not sure why the web package-lock has so many changes, otherwise looks great
sliptype
approved these changes
Aug 17, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Amazing!
Apparently @rickyrombo was able to prevent the package-lock sha changes with these steps:
- Nuke node modules in each package and at root
- Clear the cache npm cache clear --force
- Make sure git is clean and npm i at root
Not sure if that works for you
Co-authored-by: Sebastian Klingler <sliptype@gmail.com>
…oject/audius-client into rj-scrypt-account-sagas
Collaborator
|
Preview this change https://demo.audius.co/rj-scrypt-account-sagas |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add scrypt & account sagas after pair with @dylanjeffers
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested locally with uncommented code in mobile sagas. Started to get past the initial account fetch and onto some local storage stuff.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.