This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Fix wallet-client usages#1726
Merged
Merged
Conversation
sliptype
approved these changes
Aug 16, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Why do we have to use the [context, fn] syntax for walletClient but not for audiusBackendInstance for example?
Contributor
Author
class vs function returning object. maybe another case for using functions like you said :) |
Collaborator
|
Preview this change https://demo.audius.co/dj-fix-wallet-client-usages |
sliptype
pushed a commit
that referenced
this pull request
Aug 16, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes wallet-client usages, using redux-saga context arrays