This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-815] Fix electron update#1717
Merged
Merged
Conversation
sliptype
commented
Aug 15, 2022
| if ( | ||
| fs.existsSync(path.resolve(app.getAppPath(), `web-update/${buildName}`)) | ||
| ) { | ||
| const buildPath = appDataPath(`web-update/packages/web/${buildName}`) |
Contributor
Author
There was a problem hiding this comment.
Not sure why packages/web wasn't needed before?
Collaborator
|
Preview this change https://demo.audius.co/sk-fix-electron-update |
Kyle-Shanks
approved these changes
Aug 15, 2022
raymondjacobson
approved these changes
Aug 15, 2022
sliptype
added a commit
that referenced
this pull request
Aug 18, 2022
* Add extends null * Use getPath to locate update builds instead of getAppPath * Remove extends null * Fix typo
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
app.getPath('appData')instead ofapp.getAppPathto store/retrieve the update builds becauseapp.getAppPathcan't apparently be modified when the app is built using electron-build (it's packaged into a single file)appDataPathhelperDragons
I would like to test this on windows. Does anyone have a windows machine to test on?
Also need prevent auto updater from downloading full update if only a patch version is required (still think this is happening), will address in separate pr
How Has This Been Tested?
Tested via
npm run electron:stageandnpm run dist:stageHow will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.