This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-745, C-746, C-747, C-748, C-750, C-752, C-811, C-812] New Tables#1700
Merged
Conversation
1430cbb to
f9dda28
Compare
facd662 to
c66c27a
Compare
2f9ceef to
24f474d
Compare
sliptype
approved these changes
Aug 15, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Amazing stuff dude! This all looks great
Might be cool to rename the new table Table and the old one TableLegacy or something
| ) : null} | ||
| {isNewTablesEnabled ? ( | ||
| <TableComponent | ||
| // @ts-ignore |
Contributor
Author
There was a problem hiding this comment.
This was due to artistName not being present in both the nft playlist table columns and the tracks table columns. Not sure what the best way to guarantee that the columns correspond to the correct type of table
24f474d to
a87f5cc
Compare
Collaborator
|
Preview this change https://demo.audius.co/kj-New-Tables |
…new table and table components for testing, and replace the tables in the favorites page, history page, and collection pages for testing
…eral table utils and components to better files, and add a collectibles table for the collectibles playlist
a87f5cc to
887a82e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add react-table and react-virtualized, create new components for the new table and table components for testing, and replace the tables in the favorites page, history page, and collection pages for testing
Will add this to a subdomain for easy testing and feedback
Description
Dragons
Lots of updates here and things that are still to update after initial review and feedback.
Known Issues
How Has This Been Tested?
Lots of testing done, lots of testing to go
How will this change be monitored?
👀
Feature Flags
NEW_TABLESfeature flag added