This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-545] [PAY-542] Buy $AUDIO tile on $AUDIO page#1667
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/mjp-cb-audio-page |
2057ec1 to
ec541b4
Compare
Collaborator
|
Preview this change https://demo.audius.co/mjp-cb-audio-page |
dharit-tan
approved these changes
Aug 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the tile on the $AUDIO rewards page to have a "Buy with Coinbase" button and match the new redesign.
Figma
Note:
TODOs:
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
Will be updating this to the full changes once we have support for other payment providers.
Getting the Coinbase logo inline and sized appropriately was a bit trial-and-error heavy... it seems like we could do this with some maths using a constant font ascender height but I was lazy and eyeballed it
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.