This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-401] Add Linear-style patch updates for web assets for the desktop app#1544
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/kj-Add-web-patch-update-for-desktop-app |
sliptype
approved these changes
Jul 1, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Amazing! Looks great, had a couple nits
| left: 0; | ||
|
|
||
| z-index: 1; | ||
| z-index: 14; |
Contributor
There was a problem hiding this comment.
Could we add this to zIndex.ts?
99f25cb to
00fcc1c
Compare
raymondjacobson
approved these changes
Jul 1, 2022
Collaborator
|
Preview this change https://demo.audius.co/kj-Add-web-patch-update-for-desktop-app |
00fcc1c to
840632c
Compare
Collaborator
|
Preview this change https://demo.audius.co/kj-Add-web-patch-update-for-desktop-app |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dragons
If there are any edge cases or errors within this that might pop up that should be covered, let me know 🙏
How Has This Been Tested?
Lots of manual testing
How will this change be monitored?
Will do more testing on the actual desktop app when this hits prod
Feature Flags
N/A