This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Deploy Storybook to stems.audius.co upon Stems commit to main#1543
Merged
Conversation
sliptype
approved these changes
Jul 1, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Amazing! This is gonna be great for design peeps to have access to
| at: ./ | ||
| - run: | ||
| name: install wrangler | ||
| command: "cd packages/stems && npm install @cloudflare/wrangler" |
Contributor
There was a problem hiding this comment.
You shouldn't need quotes here and you can even break it into two lines using the | operator!
| const isEmbed = pathname.startsWith('/embed') | ||
| const is204 = pathname === '/204' | ||
|
|
||
| if (isBot || isEmbed || is204) { |
Contributor
There was a problem hiding this comment.
We probably don't need a lot of this stuff, like the GA and sitemap logic
| packages/stems/.* run-stems-workflow true | ||
| .circleci/.* run-web-workflow true | ||
| .circleci/.* run-mobile-workflow true | ||
| .circleci/.* run-stems-workflow true |
Contributor
There was a problem hiding this comment.
This isn't strictly necessary bc we don't have any CI that runs on stems conditionally, but good to have in case we ever add it
Collaborator
|
Preview this change https://demo.audius.co/nkang--deploy-storybook-new-new |
Collaborator
|
Preview this change https://demo.audius.co/nkang--deploy-storybook-new-new |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Tested by changing the regex to the name of this branch; here is the successful job: https://app.circleci.com/pipelines/github/AudiusProject/audius-client/6205/workflows/d920b8e6-c56f-40f3-a07a-55f8ba8cf2ae/jobs/48965
And the Storybook is up at stems.audius.co
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.