This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Use ports 3011 and 3012 for mobile stage/prod#1522
Merged
Conversation
raymondjacobson
approved these changes
Jun 27, 2022
sliptype
approved these changes
Jun 27, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks! Let's blast out on slack so people update their local env files and avoid confusion when this gets merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes mobile stage/prod runs of web to use 3011 and 3012 instead of 3001 and 3002 to avoid conflicts with normal web
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
Adds
--no-overridesto our npm scripts to prevent them from overriding the port back to 3001/3002. Should be fine, ran into no problems locally.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested locally both stage and mobile-stage
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.